ryanoasis / nerd-fonts

Iconic font aggregator, collection, & patcher. 3,600+ icons, 50+ patched fonts: Hack, Source Code Pro, more. Glyph collections: Font Awesome, Material Design Icons, Octicons, & more
https://NerdFonts.com
Other
54.57k stars 3.65k forks source link

"Fork us on GitHub" Label on Homepage Covering One of Navbar Option (in Small Screen) #1366

Closed iamRabia-N closed 1 year ago

iamRabia-N commented 1 year ago

🗹 Requirements

🎯 Subject of the issue

Experienced behavior: "Fork us on GitHub" label is covering one of homepage navbar option in small screen.

Expected behavior: Label correctly aligned on the right side.

★ Screenshots (Optional)

Current Design

img (6)

Expected Updated Design

img (7)

Kindly assign me this issue.

akhileshallewar880 commented 1 year ago

Hi, I'm interested in working on this issue. Could you please assign it to me....

AnshikaGupta6112 commented 1 year ago

Hi, I'd like to take on this task. Can you please assign it to me?

Finii commented 1 year ago

Thank you for reporting the issue!

I believe instead of shrinking the label it would be better to make it click-through? It is quite unreadable with the very small font.

There also seems to be something broken with the tabs rescaling. If the window gets smaller and smaller, first the tabs overflow in a second line, and then the short words are used instead (and then the font size is decreased):

image

image

image

image

image

Finii commented 1 year ago

Ugg, I have no experience here, now three people want to be assigned? What shall I do :-}

But then, this is at least two different problems... :thinking:

Finii commented 1 year ago

Hmm, the tab code is here: https://github.com/ryanoasis/nerd-fonts/blob/gh-pages/_includes/topnav.html That seems to be a general Jekyll problem?

ghost commented 1 year ago

hey @Finii can you please assign this task to me? I can do this for you! or Is this issue already done?

Finii commented 1 year ago

@APURVA-MOGAL

See my answer above

I have no experience [with Hacktoberfest], now three people want to be assigned? What shall I do :-}

Which sub-topic do you want to do? Maybe we can split this in two (if that is reasonable)

Viswaraje commented 1 year ago

Hello @Finii ,I would like to work on this issue if available.

Finii commented 1 year ago

This will be closed by #1373 ; unfortunately I was not able to set the assigment here.

But I will transfer the second half of this discussion to a new issue.

Finii commented 1 year ago

New Issue is

Thanks for your interest and help!

Finii commented 1 year ago

Solved via #1373

github-actions[bot] commented 6 months ago

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.