Closed VitthalGund closed 11 months ago
Thanks for the nice PR @VitthalGund! I really like the new button.
I added three more commits. When you agree with them we can pull... ?
Edit: Fix typo
Hmm, I added the
Fixes: #xxxx
syntax to the commit aec6b8d message to get the Issue-auto-close mechanism to work, but for some reason the Issues are not really linked to the PR.
Before that I added the same text to this PR's description above.
I have no clue why the linking does not work here :thinking: Will close the Issues then after pulling manually.
And also in the Issues list, this PR is not shown for the Issues. Maybe I confuse it with Gitlab :grimacing:
Sorry for the force push.
Yes, I totally agree with these changes, as they remove the dependency on Font Awesome's CSS for a single icon. I actually forgot that I can use Nerd Font here. While creating the issue, I used the Nerd Font only in my local environment, but I forgot to push it to the GitHub repo. As you have removed that comment, that's good, and I will create new pull requests with these commits.
Hmm, I added the
Fixes: #xxxx
syntax to the commit aec6b8d message to get the Issue-auto-close mechanism to work, but for some reason the Issues are not really linked to the PR.
Before that I added the same text to this PR's description above.
I have no clue why the linking does not work here 🤔 Will close the Issues then after pulling manually.
And also in the Issues list, this PR is not shown for the Issues. Maybe I confuse it with Gitlab 😬
Sorry for the force push.
I appreciate your efforts to link the issues and your diligence in making sure everything is properly connected. Sometimes, these linking mechanisms can be a bit tricky to navigate, and it's not uncommon to encounter issues.
No need to apologize; your dedication to ensuring that everything is in order is commendable. I'll go ahead and close this issue as per your request. I will create a new one with the comments removed in the title, and we'll continue from there.
Thank you for your contributions and your attention to detail.
Oh there is no need to close this and reopen a new PR.
I pushed my commits to your repo.
I just need to push 'pull' and we are done, if you like.
Force push to rebase
Thanks for the excellent work! :+1:
Was not sure if you also wanted to do Issue 1375; but I already took so much time of yours and there was one person asking. Hope it is ok I assigned them. :see_no_evil:
Hi @Finii,
Thank you for your understanding, and I appreciate your willingness to help with Issue #1375. It's completely fine that you assigned someone else to the task, as collaboration is what makes open source projects thrive.
By the way, I noticed that we've had some good discussions here, and I'd like to connect with you on LinkedIn if that's something you're comfortable with. It would be great to stay in touch and continue sharing insights related to our common interests.
Please feel free to connect with me here on LinkedIn, and let me know if there's anything else you'd like to discuss or collaborate on in the future.
Looking forward to staying connected, and thank you again for your contributions to the project! I'm looking forward to contributing to more projects in the future.
Best regards, Vitthal Gund
Just checked the fixed all-icons-circle on a windows machine with Edge (usually I am on some Linux with Firefox or Chromium), and noticed the nice button again, really like it :green_heart:
Sorry, I have no LinkedIn.
Just checked the fixed all-icons-circle on a windows machine with Edge (usually I am on some Linux with Firefox or Chromium), and noticed the nice button again, really like it 💚
Sorry, I have no LinkedIn.
Hey @Finii,
Thank you for your kind words! I'm glad to hear that you liked the button on a Windows machine with Edge. Your feedback and positive comments are greatly appreciated, and it's always rewarding to know that the changes are making a positive impact.
No worries about LinkedIn; everyone has their preferences when it comes to social platforms. I completely respect that. 😊
If you ever have any more feedback or suggestions in the future, please don't hesitate to share. Your insights are valuable to the project.
Thanks again for your support and happy coding!
Best regards, Vitthal Gund
Description
Implemented Solution 2 to address the user experience issue with the "Fork-me" banner on smaller screens. Added a GitHub icon in the bottom left corner with margin and padding. This icon serves as a persistent and easily accessible link to the GitHub repository.
Requirements / Checklist
What does this Pull Request (PR) do?
This pull request enhances the user experience by providing a persistent link to the GitHub repository through a GitHub icon in the bottom left corner of the page.
How should this be manually tested?
Any background context you can provide?
This PR is a response to issue #1372, which identified an issue with the "Fork-me" banner on smaller screens.
What are the relevant tickets (if any)?
This PR is related to issue #1372.
Fixes: #1366 Fixes: #1372
Screenshots (if appropriate or helpful)
Before:
After: