ryanoasis / nerd-fonts

Iconic font aggregator, collection, & patcher. 3,600+ icons, 50+ patched fonts: Hack, Source Code Pro, more. Glyph collections: Font Awesome, Material Design Icons, Octicons, & more
https://NerdFonts.com
Other
54.89k stars 3.65k forks source link

Font Linux symbols aren't present #138

Closed agriffis closed 7 years ago

agriffis commented 7 years ago

The screenshot in the README shows the Font Linux symbols starting at 0xf100. However they don't seem to be present when I load DejaVu Sans Mono Nerd Font Complete Mono.ttf in fontforge:

screenshot from 2017-03-07 17-37-56

My setup

ryanoasis commented 7 years ago

Thanks again @agriffis,

Confirmed that the readme gives the wrong codepoints (it gives the original codepoints which cannot be used due to conflict)

Discussed on the gitter chat

ghost commented 7 years ago

They were moved to f3xx, instead of f1xx. Just found them kinda randomly looking for them. I don't know how to update the image though, I tried but its hard to replace the 1 with a 3 and make it blend in.

agriffis commented 7 years ago

@No0n3Left you just need an updated screenshot. Here's the one from gitter conversation.

screenshot from 2017-03-08 20-23-33

I thought about updating it too, but I was surprised to see readme.md making image references from the wiki. I haven't seen that technique before on github, so I left off.

ryanoasis commented 7 years ago

I thought about updating it too, but I was surprised to see readme.md making image references from the wiki. I haven't seen that technique before on github, so I left off.

Yeah that might not be the best place to put these images going forward if it's harder for people to contribute.

I think I carried that method over from VimDevIcons but in that project the purpose was to offload the images to reduce download size when users update their plugin.. in Nerd Fonts that's probably a stupid reason because the repo is already so large that a few additional images shouldn't matter.

Any thoughts anyone else?

PrzemekSkw commented 7 years ago

@ryanoasis Hi, will You be so nice and help me add fedora logo to my terminal theme? I use zsh shell and tilix terminal. I install Powerlevel9k theme and add some codes to .zshrc file: `POWERLEVEL9K_MODE='awesome-patched' source ~/Programy/powerlevel9k/powerlevel9k.zsh-theme SAVEHIST=100 HISTFILE=~/.zsh_history

POWERLEVEL9K_STATUS_VERBOSE=false POWERLEVEL9K_STATUS_OK_IN_NON_VERBOSE=true POWERLEVEL9K_PROMPT_ON_NEWLINE=true POWERLEVEL9K_SHORTEN_DIR_LENGTH=2 POWERLEVEL9K_LEFT_PROMPT_ELEMENTS=(os_icon battery dir_writable dir) POWERLEVEL9K_RIGHT_PROMPT_ELEMENTS=( status ip time) POWERLEVEL9K_OS_ICON_BACKGROUND="white" POWERLEVEL9K_OS_ICON_FOREGROUND="black" POWERLEVEL9K_DIR_HOME_FOREGROUND="white" POWERLEVEL9K_DIR_HOME_SUBFOLDER_FOREGROUND="white" POWERLEVEL9K_DIR_DEFAULT_FOREGROUND="white" POWERLEVEL9K_TIME_FORMAT="%D{%H:%M \uE868 %d.%m.%y}"

POWERLEVEL9K_BATTERY_CHARGING='yellow' POWERLEVEL9K_BATTERY_CHARGED='green' POWERLEVEL9K_BATTERY_DISCONNECTED='$DEFAULT_COLOR' POWERLEVEL9K_BATTERY_LOW_THRESHOLD='10' POWERLEVEL9K_BATTERY_LOW_COLOR='red' POWERLEVEL9K_BATTERY_ICON='\uf1e6 '`

and my terminal looks like this: tilix

Now I want to add fedora logo after linux logo. Can You help me please?

agriffis commented 7 years ago

@PrzemekSkw This is not the right place to ask for help. Try gitter

@ryanoasis I think we can just put these images in the repo like you suggested. They're small beans compared to the fonts themselves. I'll make a PR that does that and then fixes this issue.

ryanoasis commented 7 years ago

@PrzemekSkw Love your desktop wallpaper. Yeah this is probably not the best place for this as @agriffis mentioned but one thing you will have to change the mode to the nerd fonts one. Honestly I am not sure the best way to modify a specific segment to insert a specific glyph.

@agriffis Yes that is best thanks. I agree original reason I gave makes no sense. I saw the PR thanks for that. Will merge by this weekend :+1:

PrzemekSkw commented 7 years ago

@ryanoasis I find solution thx :) That's the wallpaper: http://wallpapermonkey.com/wp-content/uploads/2016/08/star-wars-wallpaper-iphone-HD10.jpg

github-actions[bot] commented 1 year ago

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.