ryanoasis / nerd-fonts

Iconic font aggregator, collection, & patcher. 3,600+ icons, 50+ patched fonts: Hack, Source Code Pro, more. Glyph collections: Font Awesome, Material Design Icons, Octicons, & more
https://NerdFonts.com
Other
54.57k stars 3.65k forks source link

Add font: 0xProto #1381

Closed piraces closed 11 months ago

piraces commented 1 year ago

Description

Add new font 0xProto

Requirements / Checklist

What does this Pull Request (PR) do?

Adds the font 0xProto

How should this be manually tested?

N/A

Any background context you can provide?

I followed the entire contributing guide and tried to base this on other fonts added in successfully merged PRs.

What are the relevant tickets (if any)?

Closes #1379

Screenshots (if appropriate or helpful)

N/A

piraces commented 1 year ago

@all-contributors please add @piraces for code

allcontributors[bot] commented 1 year ago

@piraces

I've put up a pull request to add @piraces! :tada:

piraces commented 1 year ago

Hi there! First time contributing to Nerd Fonts. I followed the entire contributing guide and tried to base this on other fonts added in successfully merged PRs.

Please let me know if I have something wrong πŸ™

Finii commented 1 year ago

Forgot to write first of all:

Thank you for the PR :-)

piraces commented 1 year ago

Hi @Finii, first of all thank you for all the explication! It´s awesome to contribute to a repo and have this kind of warm welcoming ☺️

I think I understood the process now. I have made the suggested changes in overwriting the same commit and "force pushing" (let me know if you are not ok with "force pushes").


Off-topic (kind of): thinking about the contributing.md, adding a new font guide section, I was thinking it may be useful to change it with this "new" steps (I can try to work on that too). Should we track this proposal in a new issue or discussion? Thanks! πŸ‘

Finii commented 1 year ago

I wrote something on adding fonts here:

image

and "force pushing" (let me know if you are not ok with "force pushes")

Force pushes are absolutely ok in PRs (and better than having 10 commits that fix fixes ;)

Off-topic (kind of): thinking about the contributing.md, adding a new font guide section, I was thinking it may be useful to change it with this "new" steps (I can try to work on that too). Should we track this proposal in a new issue or discussion?

Ah, that is rather old and I completely forgot that section. I'm not so sure with add-a-font PR; in principle we would need to fix our repo setup first which we struggle since some years and there is no solution in sight. And adding a new font is - in contrast to when that paragraph had been added - rather trivial. Hmm. The problem is that this repo grew exponentially with each added font, this is not sustainable.

I still have no solutions for the problems, and the repoRelease: false is just the first ministep in the right direction but not sufficient I fear.

What I wanted to say: I would rather not promote add-a-font PRs. I really would love fix-a-bug PRs or something ;-D

Edit: Fix typos

piraces commented 1 year ago

I just have made the changes.

What I wanted to say: I would rather not promote add-a-font PRs. I really would love fix-a-bug PRs or something ;-D

I completely understand your point, if I have more time I will work on bugs or something related better than new fonts πŸ˜„

adrianvalenz commented 1 year ago

This looks almost good! :-)

Adding a new font is of course always also kind of 'political'. Is the font interesting enough? Is there demand? Etc. That is of course hard for newly created fonts.

Can I just comment to support this PR...0xProto is an amazing font to work with.

Finii commented 1 year ago

I mark this as ready now (i.e. I will update the font just on release, if need be). Thank you for the work :+1:

Ah, I will quickly add a commit that unifies the readme style.

piraces commented 1 year ago

Thank you for all @Finii !! πŸ‘

ffainy commented 11 months ago

0xProto is my favorite code font and I'm glad it's joining nerd font family. Thanks to all of you for your efforts πŸ‘