search

ryanoasis / nerd-fonts

Iconic font aggregator, collection, & patcher. 3,600+ icons, 50+ patched fonts: Hack, Source Code Pro, more. Glyph collections: Font Awesome, Material Design Icons, Octicons, & more
https://NerdFonts.com
Other
54.57k stars 3.65k forks source link

doc: Correct name for AnonymicePro Nerd Font #1385

Closed kingarrrt closed 1 year ago

kingarrrt commented 1 year ago

Description

The AnonymicePro Nerd Font is incorrectly named Anonymice Nerd Font.

Requirements / Checklist

What does this Pull Request (PR) do?

How should this be manually tested?

Any background context you can provide?

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

Finii commented 1 year ago

Good catch!

Thanks for the PR!

Hmm, I see more strangenesses...:

image

Some have Nerd Font in the listed name, and some dont. :thinking:

Also checked fonts.json, but there AnonymicePro is correct.

Finii commented 1 year ago

@allcontributors please add @kingarrrt for doc

allcontributors[bot] commented 1 year ago

@Finii

I've put up a pull request to add @kingarrrt! :tada:

Finii commented 1 year ago

Maybe you like to comment on this...:

image

I would drop the Win-Linux-Mac indicators, the table would get vertically condensed - and the indicators are defunct anyhow.

Then we should unify the naming, add - or remove - the Nerd Font part from the patched font names (column 1)?

The column names (column 1 and 2) are also rather ... similar Font Name and Font Name and Repo... Maybe change first column header to Patched Font Name?

kingarrrt commented 1 year ago

Yes re defunct Win-Linux-Mac indicators.

It looks like the Patched Fonts table could be generated from fonts.json and the fonts' README.md files to ensure correctness.

Finii commented 1 year ago

could be generated from fonts.json

Excellent idea! :+1:

(Except at least ProFont which has more than one entry in the table because of different versions. Hmm, I seem to remember that there are other fonts also with a variety of versions. But that is just a detail.)

I would even put the version information into fonts.json. We could reuse that information for nerdfonts.com then.

Are you interested in implementing something? Otherwise I would code something up.

kingarrrt commented 1 year ago

Very sorry, I don't have bandwidth to implement.