feat: add Geist Mono - Githubissues

ryanoasis / nerd-fonts

Iconic font aggregator, collection, & patcher. 3,600+ icons, 50+ patched fonts: Hack, Source Code Pro, more. Glyph collections: Font Awesome, Material Design Icons, Octicons, & more

https://NerdFonts.com

Other

53.79k stars 3.62k forks source link

feat: add Geist Mono #1398

Closed QuiiBz closed 10 months ago

QuiiBz commented 10 months ago

Description

Add the Geist Mono font.

Requirements / Checklist

[x] Read the Contributing Guidelines
[x] Verified the license of any newly added font, glyph, or glyph set

What does this Pull Request (PR) do?

Add the Geist Mono font.

How should this be manually tested?

N/A

Any background context you can provide?

Not sure if I followed all the steps correctly, I was stuck at the fourth step but it seems like it's not required.

What are the relevant tickets (if any)?

N/A

Screenshots (if appropriate or helpful)

N/A

Finii commented 10 months ago

Lets see what is special with Geist ;-)

Easy to distinguish one and small-ell (1 vs l)
Impossible to distinguish zero and capital-Oh (0 vs O)
It has a tilde-minus ligature (?! Which language uses that?)

I was just curious.

QuiiBz commented 10 months ago

Thanks for the quick review! I addressed all your comments.

But this fails to explain why the font should be added. There seems to be no Issue or Discussion. Also maybe missing is an explanation what makes this font great ;-)

Apologize for this - this font is very new (released yesterday), made specifically for developers and designers (as per their README). I patched the font locally to use it in my development environment and thought that other folks might show interest in using it with Nerd Fonts.

I totally understand if you don't accept fonts that are brand new / not widely used yet though!

rauchg commented 10 months ago

I'd love to see this font as an avid user of nerdfonts.com 😁

metruzanca commented 10 months ago

Was going to make a PR for Geist as well. I'm a huge fan of nerd fonts and a total Vercel simp. Would love the convenient way to get the font setup on all machines.

I'd also like to add that its a bit easier to get a feel for the font and understand the reasoning behind it via the https://vercel.com/font

FormalSnake commented 10 months ago

I also would love this.

BoxingOctopus commented 10 months ago

I just started using Geist Mono in my IDE, would love to be able to use it in my terminal as well! +1-ing this.

Finii commented 10 months ago

@QuiiBz Thanks for keeping this up to date :+1:

I really need to create at least a list of fonts to include in v3.1, but there is so much to do. And then there is the inclusion of simple-icons that I would really like for that revision. So many decisions... I guess the Cascadia Code problems will not be solved with 3.1, not enough time...

FormalSnake commented 10 months ago

Nice that it was merged, but I cannot find the font.

Finii commented 10 months ago

Nice that it was merged, but I cannot find the font.

I guess you have to wait until v3.1.0 is really released :laughing:

Albeit I would have loved to trigger the release this weekend, we still have to wait for the decision on RFN of Monaspace. Hopefully that will be Monday/Tuesday or something.

FormalSnake commented 10 months ago

Lmao, that is ok. But what is it with companies releasing fonts lately 🤣

Finii commented 10 months ago

@allcontributors pleas add @QuiiBz for code

allcontributors[bot] commented 10 months ago

@Finii

I've put up a pull request to add @QuiiBz! :tada:

ruantiengo commented 6 months ago

Thank you :)