Closed julien-blanchon closed 9 months ago
To patch:
find src/unpatched-fonts/Monaspace*/ -name "*.otf" -exec fontforge --script ./font-patcher {} --complete --debug 2 \;
I hope v3.0.3 is coming soon with it 🤗
Thanks for the PR! (for my own Issue ;-)
From what I gleamed you did not add a license file. I can add that, and I would like to change the directory structure as well. Nothing needs to be done from your side.
But what I would like to do is reducing the number of weights. Do you really think all the weights are useful?
I hope v3.0.3 is coming soon with it 🤗
I am about to finalise 3.1.0, writing it up in #1404, but slow going as I have to work 'for my meals' in parallel ;)
Thanks !
I think the License+Readme are on subdirectories for each font. Sure feel free to fix anything you like <3 Yes I don't think we need that much font, we can maybe prune some file to reduce the size
I am about to finalise 3.1.0, writing it up in #1404, but slow going as I have to work 'for my meals' in parallel ;)
Haha no worries, I think many people are alredy waiting for Nerd Font to add Monaspace to use it in vs-code
use it in vs-code
Unfortunately there is a bug peculiarity with Visual Studio 2022 that breaks on a lot fonts and that might need a fix beforehand? See #1242
Well, that is not VS-Code, but still related maybe.
Force push because I had one name wrong :grimacing:
Fixing shellcheck issues (forgot to run that locally), force push imminent...
To patch:
find src/unpatched-fonts/Monaspace*/ -name "*.otf" -exec fontforge --script ./font-patcher {} --complete --debug 2 \;
Well, I usually run
$ NERDFONTS="--debug 2" bin/scripts/gotta-patch-em-all-font-patcher\!.sh -v /Monaspace
or without debug-info and with parallel processing to be finished faster add -j
:
$ bin/scripts/gotta-patch-em-all-font-patcher\!.sh -jv /Monaspace
To see just all the re-naming and do not really patch, add --dry
to the NERDFONTS
envvar.
Edit: Additional info:
The difference is that patch em all
patches all 3 variants (Nerd Font
, Nerd Font Mono
, and Nerd Font Propo
) and respects the contents of config.cfg
(and allows to run multiple patch processes concurrently - nice if you have more cores).
FYI, I pulled this PR, built the fonts and installed the Mono variant of them. They have the same problem described in https://github.com/ryanoasis/nerd-fonts/issues/1242 where Visual Studio is unable to display the font and falls back to Courier New.
(No issues with the font in VS Code or Windows Terminal, just in Visual Studio 2022)
Basically just confirming https://github.com/ryanoasis/nerd-fonts/pull/1405#issuecomment-1805455254 is true.
They have the same problem described in #1242 where Visual Studio is unable to display the font and falls back to Courier New.
Working on this now with 1st priority (i.e. this night). Stole the gaming laptop from one of my kids to have a real Windows machine next to me :grimacing: Installing Visual Studio 2022 Community
...
Hope #1242 is fixed with #1406, any volunteers to test welcome (I need sleep)
@allcontributors please add @julien-blanchon for code
@Finii
I've put up a pull request to add @julien-blanchon! :tada:
Wow it's already ready, thanks you very much
With https://github.com/ryanoasis/nerd-fonts/pull/1406 merged, can Monaspace be merged now too? 😻
We are still waiting for upstream (i.e. @idan) on a naming decision (see [1]).
If we release now the patched font will (have to) be called MoniSpace Nerd Font
(or similar).
The release can/will be triggered once we have a decision.
(Well, and after the other still open PR is/are merged, I continue adding stuff meanwhile)
[1] https://github.com/ryanoasis/nerd-fonts/issues/1403#issuecomment-1806402817
Maybe some of you want to try the patched font out, and report bugs. So we can fix the issues before release?
MonispaceNeonNerdFont.tar.xz.gz
Thank you!
P.S.: The archive is tar.xz
for good compression and gz
because Github does not support xz
, sorry for the incenvenience
@Finii Can confirm that this version works as expected in VS 2022! 🎉
I see the preview for the new font on the NerdFonts.com sit, but the download does not work (and I could not find the patched fonts in the repo yet). Am I too early? Is everything still being deployed? 😄
@bradwilson
I see the preview for the new font on the NerdFonts.com sit, but the download does not work (and I could not find the patched fonts in the repo yet). Am I too early? Is everything still being deployed? 😄
See
Description
Added and patched Github Monaspace
Requirements / Checklist
What does this Pull Request (PR) do?
How should this be manually tested?
Any background context you can provide?
What are the relevant tickets (if any)?
Closes https://github.com/ryanoasis/nerd-fonts/issues/1403
Screenshots (if appropriate or helpful)