search

ryanoasis / nerd-fonts

Iconic font aggregator, collection, & patcher. 3,600+ icons, 50+ patched fonts: Hack, Source Code Pro, more. Glyph collections: Font Awesome, Material Design Icons, Octicons, & more
https://NerdFonts.com
Other
53.46k stars 3.61k forks source link

Update nerd-fonts-generated.css #1416

Closed dnoice closed 9 months ago

dnoice commented 9 months ago

Description

The css 'speak' property is not widely supported and is currently not a standard property. If you're using it to prevent screen readers from reading certain elements, a more standard approach is to use the aria-hidden="true" attribute in your HTML.

This will hide the span with the class nf from screen readers. This is a more widely supported and standard way of controlling how screen readers interact with your elements.

it's really not much to get excited about, I just noticed it, and wanted to bring it up to your attention. the line has been wrapped in a comment.

/ speak: none; /

Finii commented 9 months ago

Thanks for the PR!

I'm no web programmer and such details are beyond me, so we must rely on expert like you :-)

dnoice commented 9 months ago

oh, no problem what so ever, in fact github CoPilot caught it, I was just being a good steward of information flow

On Tue, Nov 14, 2023 at 4:43 AM Fini @.***> wrote:

Thanks for the PR!

I'm no web programmer and such details are beyond me, so we must rely on expert like you :-)

— Reply to this email directly, view it on GitHub https://github.com/ryanoasis/nerd-fonts/pull/1416#issuecomment-1810135234, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWSIABIEMTUJKRWAM7OOGGTYENROZAVCNFSM6AAAAAA7KXD7WGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJQGEZTKMRTGQ . You are receiving this because you authored the thread.Message ID: @.***>