search

ryanoasis / nerd-fonts

Iconic font aggregator, collection, & patcher. 3,600+ icons, 50+ patched fonts: Hack, Source Code Pro, more. Glyph collections: Font Awesome, Material Design Icons, Octicons, & more
https://NerdFonts.com
Other
53.46k stars 3.61k forks source link

Increase Powerline glyph overlap #1419

Closed Finii closed 9 months ago

Finii commented 9 months ago

Description

[why] We still fight with the faint lines on the big side of the powerline glyphs. They come from the LCD antialiasing mode that has problems with the borders.

Other fonts use far more overlap. We use only a modest amount of overlap (2% of the width).

[how] As the other fonts do, increase the overlap (to 7% now). We could not do that before, because we had no full-height 'landing platforms' on the outsides and so the triangle would look cut off at not 100% height.

Now with the landing platforms we can increase the overlap and still have nice looking triangles that visibly reach the top and bottom of the line.

Implement this only for the filled triangles to see how it goes.

Requirements / Checklist

What does this Pull Request (PR) do?

How should this be manually tested?

Any background context you can provide?

What are the relevant tickets (if any)?

Fixes #1245 (maybe, at least partially)

Screenshots (if appropriate or helpful)

image left: before, right: after

Finii commented 9 months ago

I wrote 7% in the commit message and in the comment above, but in reality it's only 6% :grimacing: