search

ryanoasis / nerd-fonts

Iconic font aggregator, collection, & patcher. 3,600+ icons, 50+ patched fonts: Hack, Source Code Pro, more. Glyph collections: Font Awesome, Material Design Icons, Octicons, & more
https://NerdFonts.com
Other
53.46k stars 3.61k forks source link

Bugfix/revert name change #1439

Closed Finii closed 9 months ago

Finii commented 9 months ago

Description

Compare discussion in #1434

This effectively reverts #1406 (Issue #1242)

Sorry for the VisualStudio 2022 users, we need to find some other solution and/or do a proper breaking change with anouncement.

Requirements / Checklist

What does this Pull Request (PR) do?

How should this be manually tested?

Any background context you can provide?

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

Finii commented 9 months ago

Example of how the naming changed in which version, ID16 is the one...

v3.0.3

======== JetBrainsMonoNerdFont-MediumItalic ========
SFNT Fullname      ID 4     JetBrainsMono NF Medium Italic
SFNT Family        ID 1     JetBrainsMono NF Medium
SFNT SubFamily     ID 2     Italic
SFNT Pref Family   ID 16    JetBrainsMono Nerd Font
SFNT Pref Styles   ID 17    Medium Italic
SFNT PS Name       ID 6     JetBrainsMonoNF-MediumItalic
PS fontname                 JetBrainsMonoNF-MediumItalic
PS fullname                 JetBrainsMono NF Medium Italic
PS familyname               JetBrainsMono NF Medium
Compatible Fullname         None
fondname                    None

v3.1.0

======== JetBrainsMonoNerdFont-MediumItalic ========
SFNT Fullname      ID 4     JetBrainsMono NF Medium Italic
SFNT Family        ID 1     JetBrainsMono NF Medium
SFNT SubFamily     ID 2     Italic
SFNT Pref Family   ID 16    JetBrainsMono NF
SFNT Pref Styles   ID 17    Medium Italic
SFNT PS Name       ID 6     JetBrainsMonoNF-MediumItalic
PS fontname                 JetBrainsMonoNF-MediumItalic
PS fullname                 JetBrainsMono NF Medium Italic
PS familyname               JetBrainsMono NF Medium
Compatible Fullname         None
fondname                    None

v3.1.1

======== JetBrainsMonoNerdFont-MediumItalic ========
SFNT Fullname      ID 4     JetBrainsMono NF Medium Italic
SFNT Family        ID 1     JetBrainsMono NF Medium
SFNT SubFamily     ID 2     Italic
SFNT Pref Family   ID 16    JetBrainsMono Nerd Font
SFNT Pref Styles   ID 17    Medium Italic
SFNT PS Name       ID 6     JetBrainsMonoNF-MediumItalic
PS fontname                 JetBrainsMonoNF-MediumItalic
PS fullname                 JetBrainsMono NF Medium Italic
PS familyname               JetBrainsMono NF Medium
Compatible Fullname         None
fondname                    None

Compare with these font where the familynames also differs due to abbreviations:

======== HelveticaNeueLTProBlkIt ========
SFNT Fullname      ID 4     HelveticaNeueLTPro-BlkIt
SFNT Family        ID 1     HelveticaNeueLT Pro 95 Blk
SFNT SubFamily     ID 2     Italic
SFNT Pref Family   ID 16    Helvetica Neue LT Pro
SFNT Pref Styles   ID 17    96 Black Italic
SFNT PS Name       ID 6     HelveticaNeueLTPro-BlkIt
PS fontname                 HelveticaNeueLTPro-BlkIt
PS fullname                 Helvetica Neue LT Pro 96 Black Italic
PS familyname               Helvetica Neue LT Pro
Compatible Fullname         HelveticaNeueLT Pro 96 BlkIt
fondname                    None
======== lmroman10-italic ========
SFNT Fullname      ID 4     LMRoman10-Italic
SFNT Family        ID 1     LM Roman 10
SFNT SubFamily     ID 2     Italic
SFNT Pref Family   ID 16    Latin Modern Roman
SFNT Pref Styles   ID 17    10 Italic
SFNT PS Name       ID 6     LMRoman10-Italic
PS fontname                 LMRoman10-Italic
PS fullname                 LMRoman10-Italic
PS familyname               LMRoman10
Compatible Fullname         LM Roman 10 Italic
fondname                    None
wookayin commented 7 months ago

We should have used a better version bump, say v3.2 or something.

Finii commented 7 months ago

We should have used a better version bump, say v3.2 or something.

Can you explain a bit more? 3.1.1 is a bugfix of 3.1.0. Bugfixes go in the last digit.

Because we also added some smallish stuff?

Screenshot 2024-01-01 at 14 37 25
wookayin commented 7 months ago

Because it's a bug-fix that corrects the regression(breaking change) made in v3.1.0 from v3.0.0, but also a breaking change (again). I understand fonts are not like softwares where one can easily add some compatibility layers or deprecation warnings, but in my humble opinion, one wouldn't expect significant changes when they update something only by a patch version. Anyway thanks a lot again for correcting the name.

Finii commented 7 months ago

What is the breaking change? 🤔

The breaking change from 3.0.2 to 3.1.0 was make all fonts use the NF abbreviation instead of Nerd Font. The 1. bugfix from 3.1.0 to 3.1.1 undid that change. The 2. bugfix from 3.1.0 to 3.1.1 fixes the VS2022 bug in a non-regressive manner (I hope ;-)

Edit: Fix typo

Finii commented 7 months ago

The breaking change from 3.0.2 to 3.1.0 was make all fonts use the NF abbreviation instead of Nerd Font. The 1. bugfix from 3.1.0 to 3.1.1 undid that change. The 2. bugfix from 3.1.0 to 3.1.1 fixes the VS2022 bug in a non-regressive manner (I hope ;-)

Ah I see this is not correct. The situation seems to be like this:

The breaking change from 3.0.2 to 3.1.0 was make all fonts use the NF abbreviation instead of Nerd Font. The bugfix from 3.1.0 to 3.1.1 undid that change.

The VS2022 bug would be fixed by

Why is that only a draft? 🤔