ryanoasis / nerd-fonts

Iconic font aggregator, collection, & patcher. 3,600+ icons, 50+ patched fonts: Hack, Source Code Pro, more. Glyph collections: Font Awesome, Material Design Icons, Octicons, & more
https://NerdFonts.com
Other
52.63k stars 3.59k forks source link

"Patched" comic code doesnt contain icons #1446

Closed ImLvna closed 7 months ago

ImLvna commented 7 months ago

🗹 Requirements

🎯 Subject of the issue

Experienced behavior: After patching the Comic Code Ligatures font, the outputted files do not contain icons

Expected behavior: The font contains icons

Example symbols:    

🔧 Your Setup

★ Screenshots (Optional)

image image

Finii commented 7 months ago

Oh, sorry to hear of your problems!

Lets see, the codepoints you pasted above are U+E945 U+E9A2 U+E9CF U+E939.

Nerd Fonts does not patch any symbols in the E9xx range, see https://github.com/ryanoasis/nerd-fonts/wiki/Glyph-Sets-and-Code-Points#overview. What did you expect there?

Did you try any/some of the icons you can find here: https://www.nerdfonts.com/cheat-sheet (You can also enter codepoint number in hex there and see if they are in the complete set.)

PS: When self-patching do not forget to give --complete (or -c) on the command line - which you probably did.

ImLvna commented 7 months ago

Oh, im sorry. I assumed my theme used nerd fonts, and that was reinforced because i copied an icon from your website and it didnt show either. Adding --complete seems to have fixed the official icon rendering. Thank you!

github-actions[bot] commented 1 month ago

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.