ryanoasis / nerd-fonts

Iconic font aggregator, collection, & patcher. 3,600+ icons, 50+ patched fonts: Hack, Source Code Pro, more. Glyph collections: Font Awesome, Material Design Icons, Octicons, & more
https://NerdFonts.com
Other
53.46k stars 3.61k forks source link

glyph does not fill whole height, is it the problem of my terminal? #1450

Closed Sejen27 closed 5 months ago

Sejen27 commented 8 months ago

Environment OS : Ubuntu 23.10 Terminal : tmux, GNOME Terminal 3.49.92, GNOME 45 Font : Hack Nerd Font v3.1.1

2023-12-03 16-34-15 I have tried some old versions of the Hack Nerd Font at 2020 and 2021 year, but this problem still exists. What should I do to fix this ?

Finii commented 8 months ago

This looks bad, sorry to hear that.

I guess you downloaded the release artifact, let me try...

Finii commented 8 months ago

Can not reproduce.

image

This could happen if you do not select Hack Nerd Font as your font in Terminal and the glyphs come in just via font-fallback. Please show your settings.

Finii commented 8 months ago

Maybe you increase the cell spacing height?

image

Sejen27 commented 8 months ago

@Finii Thank you for your reply ! Below is my settings: Screenshot from 2023-12-04 18-59-36 I found that it was the language I used (Chinese) that caused the problem, when I change language to English, problem solved. Is there a solution if I use Chinese?

Finii commented 8 months ago

Hmm, what does it mean 'use Chinese', concrete? What would I need to do to reproduce?

I guess you use some Chinese glyphs that come in via font-fallback? What is your Chinese font? Can you paste an example as text.

Edit: Fix typo, add second paragraph

Sejen27 commented 8 months ago

The system language My chinese font is "Microsoft Yahei" (msyh.ttc, copied from Windows 10)

image image

Sejen27 commented 8 months ago

Hi @Finii , are the sizes of these glyph normal? Are they a litter small? Screenshot from 2023-12-05 11-24-02 image

Finii commented 8 months ago

Are they a litter small?

The icons are one 'cell' wide, i.e. the same width as the M. Try the Hack Nerd Font (without Mono) for bigger icons.

Sejen27 commented 8 months ago

Are they a litter small?

The icons are one 'cell' wide, i.e. the same width as the M. Try the Hack Nerd Font (without Mono) for bigger icons.

Thank You

Sejen27 commented 8 months ago

The system language My chinese font is "Microsoft Yahei" (msyh.ttc, copied from Windows 10)

image image

@Finii Did you reproduce it?Is there a solution?

Finii commented 8 months ago

This week I'm on a conference, will try to find some time experimenting. I have no idea just so.

Sent from Nine


From: Sejen27 @.***> Sent: Tuesday, December 5, 2023 10:39 To: ryanoasis/nerd-fonts Cc: Fini; Mention Subject: Re: [ryanoasis/nerd-fonts] glyph does not fill whole height, is it the problem of my terminal? (Issue #1450)

The system language My chinese font is "Microsoft Yahei" (msyh.ttc, copied from Windows 10)

@Finii Is there a solution? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

vegawong commented 6 months ago

Has the same issue, the system language set to English then it works. Has any solution to support Chinese System Language?

Finii commented 5 months ago

Sorry I can not reproduce this. Maybe try another terminal. Tilix, Kitty?