ryanoasis / nerd-fonts

Iconic font aggregator, collection, & patcher. 3,600+ icons, 50+ patched fonts: Hack, Source Code Pro, more. Glyph collections: Font Awesome, Material Design Icons, Octicons, & more
https://NerdFonts.com
Other
54.16k stars 3.63k forks source link

EnvyCodeR not on programmingfonts.org #1467

Closed JupiLogy closed 9 months ago

JupiLogy commented 9 months ago

🗹 Requirements

🎯 Subject of the issue

Experienced behavior:

Click on "preview on programmingfonts.org" button under EnvyCodeR font. Goes to programmingfonts.org but the font used in the preview is not the EnvyCodeR font.

Expected behavior: Preview on programmingfonts.org uses EnvyCodeR font.

Example symbols:

n/a

🔧 Your Setup

n/a

★ Screenshots (Optional)

n/a

Finii commented 9 months ago

Hmm, there is no Envy Code R anymore it seems, there are only 3 fonts starting with E? I am quite sure I remember that it was on programming fonts :thinking:

image

Ah yes, they had it, added in 2019 with this commit over there:

Lets see when/why it has been removed...

image

Ah ha! But in the PR mentioned above they said they asked the author for the permission to include the font. (We did the same, btw.)

Hmm, I can not find any additional information, that was not part of a PR it seems.

Plan:

Finii commented 9 months ago

https://github.com/braver/programmingfonts/issues/145

Finii commented 9 months ago

Thanks for pointing the problem out. Lets see if this can be resolved by Koen and/or Damien.

damieng commented 9 months ago

Yeah I gave permission a while back, not sure why it got removed from there and here.

JupiLogy commented 9 months ago

Looks to be resolved, thank you guys :)

github-actions[bot] commented 3 months ago

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.