ryanoasis / nerd-fonts

Iconic font aggregator, collection, & patcher. 3,600+ icons, 50+ patched fonts: Hack, Source Code Pro, more. Glyph collections: Font Awesome, Material Design Icons, Octicons, & more
https://NerdFonts.com
Other
52.86k stars 3.6k forks source link

JetBrainsMono NFM (Light, Thin, etc.) broken since v3.1.1 #1473

Closed wookayin closed 6 months ago

wookayin commented 6 months ago

🗹 Requirements

🎯 Subject of the issue

Experienced behavior:

JetBrainsMono NFM Light is broken. It has different color when rendered by some terminals, and another terminal claims that the font description "JetBrainsMono NFM" style: "Light" not found.

Looking at the binary file, { family = 'JetBrainsMono NFM Light', weight = 'Regular' } seems to work. Wait, what is "JetBrainsMono NFM Light"?

There is a font name "JetBrainsMono NFM Light" which works OK, instead of "JetBrainsMono NFM" with style/weight = Light. Font name change is an unexpected, breaking change.

Since more than two terminals have some issues with "Thin" or "Light" style font (Other weights are fine), I assume that this is a problem of Font, given that the font update was only a minor patch release.

Expected behavior:

It was fine in v3.1.0. The font renders OK in a "light" style.

Example symbols: Every single character.

🔧 Your Setup

★ Screenshots (Optional)

v3.1.1 Light, on Wezterm: see https://github.com/wez/wezterm/issues/4126

v3.1.1 Light

Look at dimmed foreground (white) color. Also, M.setup_fonts() where M is boldfaced. The color are different than setup_fonts(), both are #ffaf00.

v3.1.1 Regular: works Fine

v3.1.1 Regular

Alacritty

image
wookayin commented 6 months ago

Related #1434 #1439

wookayin commented 6 months ago

This is basically a duplicate of #1434 which reverts the breaking change made in v3.1.0.

Resolution: Use the old name JetBrainsMono Nerd Font Mono, not JetBrainsMono NFM.

Finii commented 6 months ago

Is this really solved? I cant wrap my head around all this right now, maybe because its 1st of January and I'm tired ;-) I lost track in my head what has been changed when, sorry.

wookayin commented 6 months ago

Happy new year! I can't really explain why it broke when it used the "NFM" name only for Light and Thin (probably v3.1.1 does not have these font family...), but after changing the name to what it was used to "... Nerd Font Mono" everything seems fine.

github-actions[bot] commented 1 week ago

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.