ryanoasis / nerd-fonts

Iconic font aggregator, collection, & patcher. 3,600+ icons, 50+ patched fonts: Hack, Source Code Pro, more. Glyph collections: Font Awesome, Material Design Icons, Octicons, & more
https://NerdFonts.com
Other
52.6k stars 3.59k forks source link

Ioveska Extended Widths #1475

Closed joshka closed 3 months ago

joshka commented 5 months ago

Requirements

Is your feature request related to a problem? Please describe. Iosevka fonts have Normal and Extended widths in the unpatched font. The extended width is missing in the patched fonts. The extended width matches the normal width of other fonts (Iosevka's normal width is a narrow width).

Describe the solution you'd like Include the extended width in the generated font.

Describe alternatives you've considered

Additional context

https://typeof.net/Iosevka/

image image

Font selection in iTerm2. Fonts installed via homebrew.

image image
Finii commented 5 months ago

Thanks for the suggestion!

Well, Nerd Fonts has no Extended Iosevka in the Nerd Fonts unpatched fonts...: https://github.com/ryanoasis/nerd-fonts/tree/master/src/unpatched-fonts/Iosevka So this is not a bug. Not that you said that ;-)

Iosevka has a ridiculous amount of different versions and we only patch a very limited number of them. Still too many for my taste.

Lets assume we add 'extended', in the current setup that means of course with all weights and we have 27 (Italic and Oblique, oh yes), and that for Iosevka and IosevkaTerm. Luckily for IosevkaTermSlap we reduced the number of weights to 15.

That means adding Extended equals adding 27+27+15 = 69 fonts.

Maybe self-patching is not too hard? Or only a more limited set of weights? Hmm :thinking:

Finii commented 5 months ago

The tag is not really correct, but I believe we have no "extend existing font set" tag.

Finii commented 5 months ago

If you are an Iterm2 user, is the "use build-in Nerd Font icons" not an option for you, especially if using the nightly build? When I work on Mac this is in fact my go-to option instead of a patched font.

joshka commented 5 months ago

The iTerm2 feature is not something I was aware of until now. I can't find any docs on it on the iTerm2 site, nor specific settings related to "nerd" in the UI of the stable or beta release. Nightly is probably a bit too bleeding edge for my sensibilities. I can see that there's a couple of refs in the iterm source code to nerd fonts, but can't see an obvious place where the setting surfaces in the UI. What am I missing?

Regardless, my specific situation is from the perspective of a maintainer of a rust TUI library (https://ratatui.rs/). I'm looking for good fonts that work for development of TUI apps. This generally means having good block drawing characters, legacy computing symbols etc, and then Nerd Fonts on top for my day to day use. Fira Code is my go to, but I'd consider Iosevka from time to time. It has better support for the Legacy Computing Symbols block, but I dislike the narrow normal version. Using something that's custom puts me in a place that's not useful for those that use the library.

joshka commented 5 months ago

Ah found it... that manage special exceptions button:

image
Finii commented 3 months ago

Closing because transferred to https://github.com/ryanoasis/nerd-fonts/discussions/1095

redactedscribe commented 2 months ago

+1 for inclusion of the extended version of Iosevka as I find the default to be too narrow.

joshka commented 2 months ago

+1 for inclusion of the extended version of Iosevka as I find the default to be too narrow.

Please don't write +1 comments on github like this. Use the thumbs up instead.

Finii commented 2 months ago

+1 for inclusion of the extended version of Iosevka as I find the default to be too narrow.

Please don't write +1 comments on github like this. Use the thumbs up instead.

Well, for me the difference between commenting +1 and reacting with thumbs up is that I can conveniently reach people who commented. Who comments implicitly allows to be asked stuff, i.e. gets notifications on new topic comments. If for example something is unclear with the topic discussed and I would like to ask some question people who are interested in that feature, a thumps-up reaction does not help much. So for me the difference is 'dont care too much but want to express approval' to 'approve and dont mind to get involved'. But maybe I'm imagining that :grimacing: