search

ryanoasis / nerd-fonts

Iconic font aggregator, collection, & patcher. 3,600+ icons, 50+ patched fonts: Hack, Source Code Pro, more. Glyph collections: Font Awesome, Material Design Icons, Octicons, & more
https://NerdFonts.com
Other
52.86k stars 3.6k forks source link

[Icon request] Add ChucK logo please #1489

Closed Finii closed 3 months ago

Finii commented 5 months ago

Discussed in https://github.com/ryanoasis/nerd-fonts/discussions/1479

Originally posted by **gacallea** January 10, 2024 Hi :) As the title says, I would like to suggest the addition of an icon for [Chuck](https://chuck.cs.princeton.edu). Logo is here: ![Chuck logo](https://chuck.cs.princeton.edu/doc/images/chuck-logo2023w.png) If I had the skills I'd try to patch and contribute. I hope this can be implemented. Please and thank you EDIT1: just in case, this is how I set it for the time being. Mostly posting for the extension and name: ``` [...] { "nvim-tree/nvim-web-devicons", opts = { override_by_extension = { ["ck"] = { icon = "󰧚", color = "#80ff00", name = "ChucK", }, }, }, }, [...] ```
Finii commented 3 months ago

Closing because transferred to https://github.com/ryanoasis/nerd-fonts/discussions/1095

gacallea commented 2 months ago

Hi @Finii :)

I was just checking the add chuck glyph status and I see it was removed from v3.2.0. I'd like to know if it will make it in the next one, please? No hurry/rush/pressure, just curious.

Please and thank you

Finii commented 2 months ago

Sorry, I just lack any good system for adding glyphs to the core set. I mean, selecting which should go in. usually I try to avoid it and direct people to seem inclusion in upstream icon sets. When doing 3.2.0 I had so many things to do and include, so on the glyph addition side I believe we just had old 'Ada' being added. I guess I should start a more systematic approach. But then, it is extremely hard to judge if an icon is 'important' or not.

And did I not do some more work? I remember having that icon in the editor ...

Ah, there are two Issues for the same thing :grimacing:

Ah, 1479 is a discussion and therefor not suited for 'serious work'.

Anyhow, I saw now some issues with the border, I guess that made me not-include it, because the outline was not 'clean', and manual cleanup takes some time that I could not find.

Copying the comments here:

SVG is here, quickly done using Inkscape and the original png image:

chuck

Maybe the square-brackets top and bottom are a bit thin?

image

and

Looks unclean:

image

gacallea commented 2 months ago

Hi @Finii

all fair points. What you suggest I should do? Open an issue with another repo? I vaguely recall you saying that asking more upstream could be a better idea.

Also: this was my initial request https://github.com/ryanoasis/nerd-fonts/discussions/1479 the rest of discussions (this included) you opened yourself. :D

Please and thank you

Finii commented 2 months ago

Tried to come up with some solution to the add-an-icon problem. You can see the other candidates and some meaningless metrics in the Issue linked above.