search

ryanoasis / nerd-fonts

Iconic font aggregator, collection, & patcher. 3,600+ icons, 50+ patched fonts: Hack, Source Code Pro, more. Glyph collections: Font Awesome, Material Design Icons, Octicons, & more
https://NerdFonts.com
Other
52.69k stars 3.59k forks source link

FontAwesome: Update to 6.5.1 #1563

Closed Finii closed 3 months ago

Finii commented 3 months ago

Depending on the codepoints they assign to the icons (and they do have codepoint stability it seems), we can divide the Font Awesome icons into three (artifical) regions:

Region A is their dedicated allocation within Nerd Fonts codepoint space. At F300 the next set (Font Logos) starts. For backward compatibility codepoints of existing icons in Region A have to be kept. The other codepoints (i.e. icons in Region B and C) fall to other icons sets' codepoint in Nerd Fonts space and have to be moved.

The question is how and where.

Possible scenario:

E000 - E00A         Pomicons
E0A0 - E0D4         Powerline Extra
E100 - E1FF    100
E200 - E2A9         FA Extension
E300 - E3e3         Weather
E400 - E5F9    200  (Expandion Seti)
E5FA - E6B2         Seti
E700 - E7C5         Devicons
E800 - E9FF    200
EA60 - EC1D         Codicons
ED00 - EFFF    300  Font Awesome 2
F000 - F2E0         Font Awesome (expand up to F2FF)
F300 - F372         Font Logos
F400 - F532         Octicons
F600 - F8FF    300
F0001...            MD

We could patch Region A to the codepoints of the current FA, filling the gaps with some of Region B. The rest of Region B fits into ED00 - EFFF This PR does not introduce the icons from Region C.

This PR does not introduce Regular and Solid (except where both variants were already in Font Awesome 4.3).

For licensing reasons we use the svgs and not the release font files. We loose their placement within the glyph bounding box this way, but I guess the scheme of placement we use now is not worse. For that soem actual patched fonts need to be inspected, esp the Nerd Font Propo variants.

Fixes: #1550

Requirements / Checklist

What does this Pull Request (PR) do?

How should this be manually tested?

Any background context you can provide?

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

image

hasecilu commented 3 months ago

Hi, I detected that the glyph nf-fa-circle_thin at \uf1db () now is presented as a filled circle but before it was a thin ring. This exactly glyph is used in powerlevel10k to identify sr.ht git remote, I'm adding it to lazygit with the same purpose, that's how I found the problem.

I don't know if similar problems are found in other glyphs so I can't tell the severity of the "bug".

image

Finii commented 3 months ago

Moved comment to #1596

Finii commented 3 months ago

We can the also incorporate