Open my4ng opened 2 months ago
Thanks for the nice PR!
One question: Why did you put the font file into sub-directories? Is there anything in the documentation that suggests it? I have seen this now with multiple PRs.
"is a programming font focused on source code legibility."
Well, which font does not? That slogan is even lamer than before ;-) But that seems to be the official 'subtitle'. Otoh we could add something meaningful instead, if you have any idea why it is great?
Edit:
Hmm, you ticked Read the Contributing Guidelines :thinking: Is that easy to misunderstand? I would like to improve it if needed. :thinking:
One question: Why did you put the font file into sub-directories? Is there anything in the documentation that suggests it? I have seen this now with multiple PRs.
I thought this is required in the Contributing Guidelines:
Make sure to update the correct subfolders for each font style (e.g.
src/unpatched-fonts/xyz/bold/{BOLD FONT FILES HERE}
), if applicable
Since 0xProto has released a new dedicated italic version, I thought it makes sense to put them in Regular and Italic folders separately.
Otoh we could add something meaningful instead, if you have any idea why it is great?
I think the features headings in the README are good pointers, especially clear differentiation and ligatures that do not deform.
Thanks for the feedback!
if applicable
Ah I see.
are good pointers
What do you think about .... lets see
... is a programming font with clear differentiation and ligatures that do not deform
:-)
Marking this as ready, but I will hold it back until release time, and update to whatever version is current then (maybe 2.0.1 ;)
If you like maybe you can undo the sub-directory change and put both fonts into one directory. But I can change that later if you prefer.
@allcontributors please add @my4ng for code
:thought_balloon: allcontributors has some problem? I will try again later...
@Finii
We had trouble processing your request. Please try again later.
If you like maybe you can undo the sub-directory change and put both fonts into one directory. But I can change that later if you prefer.
Yeah I saw a couple other unpatched fonts were doing that, so I just followed suit :sweat_smile:. Anyway, I have corrected that but I left the one-line description as it was.
@allcontributors please add @my4ng for code
@Finii
@my4ng already contributed before to code
Description
Update 0xProto to version 2.001. This release adds an italic family as well as several fixes and improvements.
Requirements / Checklist
What does this Pull Request (PR) do?
Update 0xProto to version 2.001.
How should this be manually tested?