ryanoasis / nerd-fonts

Iconic font aggregator, collection, & patcher. 3,600+ icons, 50+ patched fonts: Hack, Source Code Pro, more. Glyph collections: Font Awesome, Material Design Icons, Octicons, & more
https://NerdFonts.com
Other
52.6k stars 3.59k forks source link

Update 0xProto to 2.100 #1623

Open my4ng opened 2 months ago

my4ng commented 2 months ago

Description

Update 0xProto to version 2.001. This release adds an italic family as well as several fixes and improvements.

Requirements / Checklist

What does this Pull Request (PR) do?

Update 0xProto to version 2.001.

How should this be manually tested?

fontforge --script ./font-patcher src/unpatched-fonts/0xProto/Regular/0xProto-Regular.ttf --complete --debug 2
fontforge --script ./font-patcher src/unpatched-fonts/0xProto/Italic/0xProto-Italic.ttf --complete --debug 2
Finii commented 2 months ago

Thanks for the nice PR!

One question: Why did you put the font file into sub-directories? Is there anything in the documentation that suggests it? I have seen this now with multiple PRs.

"is a programming font focused on source code legibility."

Well, which font does not? That slogan is even lamer than before ;-) But that seems to be the official 'subtitle'. Otoh we could add something meaningful instead, if you have any idea why it is great?


Edit:

Hmm, you ticked Read the Contributing Guidelines :thinking: Is that easy to misunderstand? I would like to improve it if needed. :thinking:

my4ng commented 2 months ago

One question: Why did you put the font file into sub-directories? Is there anything in the documentation that suggests it? I have seen this now with multiple PRs.

I thought this is required in the Contributing Guidelines:

Make sure to update the correct subfolders for each font style (e.g. src/unpatched-fonts/xyz/bold/{BOLD FONT FILES HERE}), if applicable

Since 0xProto has released a new dedicated italic version, I thought it makes sense to put them in Regular and Italic folders separately.

Otoh we could add something meaningful instead, if you have any idea why it is great?

I think the features headings in the README are good pointers, especially clear differentiation and ligatures that do not deform.

Finii commented 2 months ago

Thanks for the feedback!

if applicable

Ah I see.

are good pointers

What do you think about .... lets see

... is a programming font with clear differentiation and ligatures that do not deform

:-)


Marking this as ready, but I will hold it back until release time, and update to whatever version is current then (maybe 2.0.1 ;)

If you like maybe you can undo the sub-directory change and put both fonts into one directory. But I can change that later if you prefer.

Finii commented 2 months ago

@allcontributors please add @my4ng for code

Finii commented 2 months ago

:thought_balloon: allcontributors has some problem? I will try again later...

allcontributors[bot] commented 2 months ago

@Finii

We had trouble processing your request. Please try again later.

my4ng commented 2 months ago

If you like maybe you can undo the sub-directory change and put both fonts into one directory. But I can change that later if you prefer.

Yeah I saw a couple other unpatched fonts were doing that, so I just followed suit :sweat_smile:. Anyway, I have corrected that but I left the one-line description as it was.

Finii commented 2 months ago

@allcontributors please add @my4ng for code

allcontributors[bot] commented 2 months ago

@Finii

@my4ng already contributed before to code

my4ng commented 1 month ago

I have updated 0xProto to 2.001