ryanoasis / nerd-fonts

Iconic font aggregator, collection, & patcher. 3,600+ icons, 50+ patched fonts: Hack, Source Code Pro, more. Glyph collections: Font Awesome, Material Design Icons, Octicons, & more
https://NerdFonts.com
Other
52.6k stars 3.59k forks source link

GohuFont question mark is upside-down #1652

Closed dsvoid closed 2 weeks ago

dsvoid commented 3 weeks ago

🗹 Requirements

🎯 Subject of the issue

Experienced behavior: GohuFont 14 Nerd Font Propo Regular has an upside-down question mark. This may be the case for the variants.

Expected behavior: Right-side up question mark.

Example symbols: "?"

🔧 Your Setup

★ Screenshots (Optional)

Untitled

Finii commented 3 weeks ago

image

Finii commented 3 weeks ago

It's in the 14 source already :thinking:

image Uni14 ok, wrong in 14

But both 11 are ok

image Uni11 and 11 ok


See issue I created in your stead upstream. Will fix it here if I find time, as upstream will most likely not change anything, Maybe use the uni version? Why using the small uni-less version :thinking: With all the icons both fonts are almost identical in size anyhow. The non-uni version had been intended for people with not much memory I guess.

Finii commented 3 weeks ago

@allcontributors please add @dsvoid for bug

allcontributors[bot] commented 3 weeks ago

@Finii

I've put up a pull request to add @dsvoid! :tada:

kierun commented 2 weeks ago

⸮ is the irony mark, isn't it? … Which is not upside-down! Isn't the Spanish question mark upside down? They appear to be

Finii commented 2 weeks ago

Yes, it is the spanish start-a-question-symbol ... like ¿Hablas español?

In the 11 px variant all is well:

image

but in the 14 px variant the upside-down one replaces the ordinary question mark, while the upside-down slot remains empty. The reason is that both glyphs have the same name (question) in the definition file, but the mapping of outlines to codepoints is by name, so it is coincidence which goes where (on build time). That is a bug in the font definition file, where the upside down question mark's outline should have a different name, for example sMoFu or the standard inverted, so that on building there is no ambiguity.

image

Also noticed now that the micro symbol is missing :unamused: Did not try to find the reason for that.