When reading the "Steps for adding a new font..." section in contributing.md, Step 4 seemed to me to be saying to commit the newly patched font files (in reality the instructions are only to commit changes to config.cfg)
Maybe this is just my brain being weird, if so feel free to close this issue =)
On the other hand, if it's helpful I have this commit that clarifies the documentation and I'd be happy to open a PR for it if you like =)
Expected behavior:
The instructions in the "Steps for adding a new font..." section in contributing.md, Step 4 clearly advises to commit only changes to config.cfg and to not commit the newly patched font files
Example symbols:
N/A
🔧 Your Setup
Which font are you using (e.g. Anonymice Powerline Nerd Font Complete.ttf)?
N/A
Where did you get the file from (download link, self patched, source downloaded from link...)
🗹 Requirements
🎯 Subject of the issue
Documentation for adding new fonts in
contributing.md
Experienced behavior:
When reading the "Steps for adding a new font..." section in
contributing.md
, Step 4 seemed to me to be saying to commit the newly patched font files (in reality the instructions are only to commit changes toconfig.cfg
)Maybe this is just my brain being weird, if so feel free to close this issue =)
On the other hand, if it's helpful I have this commit that clarifies the documentation and I'd be happy to open a PR for it if you like =)
Expected behavior:
The instructions in the "Steps for adding a new font..." section in
contributing.md
, Step 4 clearly advises to commit only changes toconfig.cfg
and to not commit the newly patched font filesExample symbols:
N/A
🔧 Your Setup
Anonymice Powerline Nerd Font Complete.ttf
)?iterm2
,urxvt
,gnome
,konsole
)?★ Screenshots (Optional)
Thanks!