Ligature support in ComicShannsMono

ryanoasis / nerd-fonts

Iconic font aggregator, collection, & patcher. 3,600+ icons, 50+ patched fonts: Hack, Source Code Pro, more. Glyph collections: Font Awesome, Material Design Icons, Octicons, & more

https://NerdFonts.com

Other

52.6k stars 3.59k forks source link

Ligature support in ComicShannsMono #1659

Closed tylerlaprade closed 1 week ago

tylerlaprade commented 2 weeks ago

Requirements

[x] I have searched the issues for my request and found nothing related and/or helpful
[x] I have searched the FAQ for help
[x] I have searched the Wiki for help

Is your feature request related to a problem? Please describe. ComicShannsMono does not have ligatures

Describe the solution you'd like I would like ligatures as seen here

Describe alternatives you've considered I can directly use this, but its Bold (and the original parent's Bold) doesn't seem to work in VSCode. Also, the spacing is too narrow.

Additional context N/A

Finii commented 2 weeks ago

What about using ComicShannsMono Nerd Font (https://github.com/ryanoasis/nerd-fonts/releases/download/v3.2.1/ComicShannsMono.zip) und pushing it through https://github.com/ToxicFrog/Ligaturizer ?

That's at least what Wayou said they did, in principle (well, taking some other upstream).

https://github.com/dtinth/comic-mono-font has some problems, that is the reason we use https://github.com/jesusmgg/comic-shanns-mono as upstream for the prepatched Comic Sans.

Seems to be a Mac-only person :thinking:

tylerlaprade commented 2 weeks ago

Okay, I will try that. Should I contribute the result back to the repo, or do auto-generated ligatures not meet the standards of this project?

Finii commented 1 week ago

I believe it would be good to at least report back here in this thread.

I think it would not be good to incorporate the ligatur-ed font into Nerd Fonts, because

a lot people do not like those ligatures
we stick with upstream (there must be severe reasons to deviate from that)

I guess the ligs could be added as Stylistic Set (maybe they are already, I never myself tried the Ligaturizer), and then contributed to upstream (i.e. Jesusmgg's repo).

tylerlaprade commented 1 week ago

I believe it would be good to at least report back here in this thread.

I successfully added the ligatures to the font.

a lot people do not like those ligatures

They are opt-in, so if people don't like them, it's no different than the font without any ligatures. I'm happy with them, since "symbols" make sense to be more formal looking than letters anyway.