fix: rename issue form files for consistency - Githubissues

ryanoasis / nerd-fonts

Iconic font aggregator, collection, & patcher. 3,600+ icons, 50+ patched fonts: Hack, Source Code Pro, more. Glyph collections: Font Awesome, Material Design Icons, Octicons, & more

https://NerdFonts.com

Other

52.6k stars 3.59k forks source link

fix: rename issue form files for consistency #1671

Closed gu5e closed 5 days ago

gu5e commented 5 days ago

Description

This PR renames the issue form files to use - instead of _. Sorry for not remembering this in #1667

Requirements / Checklist

[x] Read the Contributing Guidelines
[ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx
[x] If this contains a font/glyph add its origin as background info below (e.g. URL)
[x] Verified the license of any newly added font, glyph, or glyph set. License is: xxx

What does this Pull Request (PR) do?

It renames the issue form files to match GitHub issue form yaml file naming conventions.

How should this be manually tested?

If you have functional eyes, you can look at the filenames of the issue forms.

Any background context you can provide?

Nope.

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

Finii commented 5 days ago

to match GitHub naming conventions

The only 'convention' I could find was this:

And ISSUE_TEMPLATE/FORM-NAME.yml (with underscore in the path and dash in the file name) is far from consistent in my eyes?

Maybe you have a link to the naming convention?

[1] https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests

gu5e commented 5 days ago

Unfortunately i don't, but there's not documentation referencing that you should name the file with underscores.

gu5e commented 5 days ago

And you're also naming your github actions with dashes

Finii commented 5 days ago

Here the history of how we came to the current names (via #782)

and they still say underscore is the thing ;-)

gu5e commented 5 days ago

But you are already using dashes for the workflow file names

Finii commented 5 days ago

Some examples for repos I work with

And this

I just checked these 3, so I guess underscore is ok ;)

Finii commented 5 days ago

But you are already using dashes for the workflow file names

I have no clue why, but that tends to be what people do. The same 3 repos:

Azure of course for Microsoft

gu5e commented 5 days ago

Okay, i actually didn't know that, gonna close it. Thanks!

Finii commented 5 days ago

Thank you for caring for the details like filenames :+1: