ryanoasis / nerd-fonts

Iconic font aggregator, collection, & patcher. 3,600+ icons, 50+ patched fonts: Hack, Source Code Pro, more. Glyph collections: Font Awesome, Material Design Icons, Octicons, & more
https://NerdFonts.com
Other
54.73k stars 3.65k forks source link

Alien Icon (some Weather icons rather small) #1708

Closed vurtune closed 1 week ago

vurtune commented 2 months ago

Requirements

Problem Description

Alien  (e36e) icon is too small on FiraCode Mono

Desired Solution

Can you make a little more bigger? Like 󰢚 (f089a)

Alternatives Considered

No response

Additional Context

No response

Finii commented 1 month ago
Screenshot 2024-09-16 at 08 07 57 Screenshot 2024-09-16 at 08 08 19

The icon looks different ;-)

Hmm, the weather "extra" icons are all so small, let me find out why

Screenshot 2024-09-16 at 08 11 21

The scaling code is this (the original icon codepoint is F075 so it falls into the last of all rules:

        WEATH_SCALE_LIST = {'ScaleGroups': [
            [0xf03c, 0xf042, 0xf045 ], # degree signs
            [0xf043, 0xf044, 0xf048, 0xf04b, 0xf04c, 0xf04d, 0xf057, 0xf058, 0xf087, 0xf088], # arrows
            range(0xf053, 0xf055 + 1), # thermometers
            [*range(0xf059, 0xf061 + 1), 0xf0b1], # wind directions
            range(0xf089, 0xf094 + 1), # clocks
            range(0xf095, 0xf0b0 + 1), # moon phases
            range(0xf0b7, 0xf0c3 + 1), # wind strengths
            [0xf06e, 0xf070 ], # solar/lunar eclipse
            # Note: Codepoints listed before that are also in the following range
            # will take the scaling of the previous group (the ScaleGroups are
            # searched through in definition order).
            # But be careful, the combined bounding box for the following group
            # _will_ include all glyphs in its definition: Make sure the exempt
            # glyphs from above are smaller (do not extend) the combined bounding
            # box of this range:
            range(0xf000, 0xf0cb + 1), # lots of clouds and other (Please read note above!)
        ]}

The original set looks like this

Screenshot 2024-09-16 at 08 15 41

Ok, thank you. I will do a search for the reasons ;-D

Finii commented 1 week ago

These are the scale groups visually

image

Note the orange brackets, that scale all not-marked glyphs between them (the lots of clouds and other group).

Clearly some icons do not belong in there, and maybe this is a new group:

image

Also noticed that one wind direction is not in the wind direction group :grimacing: (F0B1)

Finii commented 1 week ago

Also noticed that one wind direction is not in the wind direction group 😬 (F0B1)

I'm sooo blind :grimacing:

image