search

ryanoasis / nerd-fonts

Iconic font aggregator, collection, & patcher. 3,600+ icons, 50+ patched fonts: Hack, Source Code Pro, more. Glyph collections: Font Awesome, Material Design Icons, Octicons, & more
https://NerdFonts.com
Other
54.67k stars 3.65k forks source link

Fonts from 2.0 release are not being correctly identified as Monospace #270

Closed notrev closed 4 years ago

notrev commented 6 years ago

🎯 Subject of the issue

Initial issue description (from 23/May/2018) I use Meslo LG M for Powerline and want to use the Nerd Fonts patched version. I tried all Meslo LG M in the repository, but none of them appeared in the gnome-terminal's fonts list. they were listed in the system, thought (in the fonts application).

I also downloaded the original ones, without any patches, and they got listed.

Anyone has any clue about how to fix this?

Update 24/May/2018 I have also tried Droid Sans, and it is not being listed too. I downloaded Terminator to see if it lists them, and it did.

Update 31/May/2018 With other people experiencing the same issue with other fonts, the issue's title was updated from "Meslo fonts not being listed on gnome-terminal" to the current one, as suggested by @gargoyle.

🔧 Your Setup

paul-court commented 6 years ago

I have the same with the three I have tried so far:- Hack, Anonymous Pro and Bitstream Vera.

I've installed "Font Manager" which has a bit more functionality than the standard Gnome "Fonts" app, and it it showing all three of these as having proportional spacing - which is why Gnome Terminal will not list them.

I downloaded the files from the release archive (https://github.com/ryanoasis/nerd-fonts/releases/tag/v2.0.0) as per the instructions.

joke2k commented 6 years ago

I tried with Fura, and I found the same issue. The gnome terminal ignore fonts with "proportional spacing". the font became proportional after the patch?

matjam commented 6 years ago

So, try this

sudo rm /etc/fonts/conf.d/70-no-bitmaps.conf

I know its not a bitmap font but I have had more luck since I did that.

joke2k commented 6 years ago

Could be works, but I don't like this solution. This package says:

Monospaced (fixed-pitch, fixed-width) or double-width (non-monospaced) glyphs version of each font

And it would be awesome to have them works without this fix

notrev commented 6 years ago

@matjam, I tried your solution, but it did not work or me. It listed a lot of new fonts, but not Meslo LG M, which is the one I want

paul-court commented 6 years ago

Workaround = Goto Releases, Click Tags, Select 1.2, Download. (https://github.com/ryanoasis/nerd-fonts/releases/tag/v1.2.0)

joke2k commented 6 years ago

@gargoyle it seems to work, with Fira font at least. Is there a bug with 2.0?

paul-court commented 6 years ago

Yes. Something has gone wrong with the build process for 2.0 and none of the fonts (None of the 6-8 that I have tried, anyway) have the correct "spacing" parameter, so they are not being recognised as monospaced fonts when they are installed.

The 1.2 ones all seem fine.

notrev commented 6 years ago

The workaround proposed by @gargoyle works, but the glyphs are small. I read that this is known and there is not much to be done because of the mono font type.

My way of solving this was to change from gnome-terminal to ROXterm, as it is very much like gnome-terminal and accepts the non-mono version of the Meslo font.

Should I close this issue, or should I leave it open, as the issue still persists for gnome-terminal?

paul-court commented 6 years ago

My gut feeling is that it would be @ryanoasis decision to close or not.

However, you might want to re-name the title since it's not only an issue with gnome-terminal. The 2.0 versions will not show anywhere when you are searching for Monospaced fonts.

Title suggestion: "Fonts from 2.0 release are not being correctly identified as Monospace"

ryanoasis commented 6 years ago

Hey thanks everyone this is definitely a big issue that I have been following along with quietly. I won't be able to contribute too much to this project for the next several months but if I get some time and there are quick wins or PRs I will do my best :smile:

xasx commented 6 years ago

They do not appear in the selection box, however, with any gconf editor one can set the font of the respective profile manually.

I used dconf-editor and modified the value in the respective profile found beneath org/gnome/terminal/legacy/profiles:

paul-court commented 6 years ago

I'm not sure I would recommend that, @xasx. The developers of gnome-terminal have deliberately put measures in place to make sure only monospaced fonts are used.

If you use a gconf editor to "get round" that limitation, then you are opening yourself up to possible problems/issues which the developers have tried to avoid or would not expect to happen.

brennanfee commented 6 years ago

@gargoyle Nice title change suggestion.

Also, your solution for Gnome terminal is great but does mean that people miss out on a lot of the improvements made in 2.0 like the addition of the Material Icons and other updates. If there is an issue with the builds in 2.0 we should probably keep this issue focused on that which, sounds like, fixes multiple problems.

xasx commented 6 years ago

@gargoyle I'd not generally recommend this. However, it is a way I found to make something work that should be actually working - that said, keep in mind that the bug is actually on NerdFonts side making it impossible for gnome-terminal to correctly detect it as being monospaced (or usable, whatever counts).

westernmagic commented 6 years ago

Reverting 31d7524 and recompiling fonts seems to solve the issue (with Fura Code and Qterminal).

philFernandez commented 6 years ago

I downloaded Terminator, which I believe is a fork of Gnome Terminal, and nerd fonts show up and work perfectly there. The functionality and settings options of Terminator and Gnome Terminal are very similar.

phcerdan commented 6 years ago

Hitting this from aur package in ArchLinux https://aur.archlinux.org/packages/nerd-fonts-complete/ , which uses latest release. Gnome terminal does not recognize most of the fonts as monospace, so they are not showing up.

haasosaurus commented 6 years ago

i fixed this in my fork, i did a pull request. i'm new at this, sorry.

https://github.com/ryanoasis/nerd-fonts/pull/283

zfil commented 6 years ago

@haasosaurus you need to do a pull request on this project not on your fork.

haasosaurus commented 6 years ago

@zfil thank you, i fixed it

haasosaurus commented 6 years ago

you can use the fonts in this branch of my fork for the time being, let me know if they work if you try them please. https://github.com/haasosaurus/nerd-fonts/tree/regen-mono-font-fix

MatthewCushing commented 6 years ago

There's a way to get around this with everything working for the Gnome-Terminal. Start up "dconf-editor" in the terminal. Then go to org>gnome>terminal>legacy>profiles:>profile id>font and change the custom value to the font you wish to use. So far the Meslo LGL font you would put in MesloLGL Nerd Font Regular 12 12 being the font size.

paul-court commented 6 years ago

@mrcush Already mentioned above why that might not be a good idea.

If you mess with dconf-editor manually, you could get the application into states the developers didn't anticipate.

MatthewCushing commented 6 years ago

@gargoyle Sorry, read through almost the whole thread and missed someone else recommending the same thing. I do think the fonts and the patcher should get fixed so that there doesn’t have to be a workaround however I don’t see any issues that could really arise except for issues with spacing if you are trying to use a non monospaced font. If you’re throwing in a monospaced font there shouldn’t be an issue.

I could be wrong though, what issues do you think could arise?

weilbith commented 5 years ago

@haasosaurus I've gone for your fork while waiting for the PR. Works well, except that some special Unicode characters are super small. Since they have a lot of details (at least more than ASCII ones), this makes them unusable. Example for this character in comparison to the rest of the prompt: 1545908301

gymgle commented 5 years ago

Nerd fonts, Awesome fonts couldn't list in terminal, so we couldn't select the font we want.

You can set any font using dconf-editor, under /org/gnome/terminal/legacy/profiles:/:<profile-id>/font.

e.g. Custom value : DroidSansMono Nerd Font Book 13

https://askubuntu.com/questions/1046871/nerd-font-not-fond-in-terminal-profile/

paul-court commented 5 years ago

@mrcush / @gymgle, yes dconf-editor can be used for a work around and in this instance the risk is probably limited to character spacing issues.

However, it shouldn't become habit to use such a tool without due consideration. Today it's just a font issue, tomorrow it could be something a bit more critical.

As an example, make a mental node of this little gem which seems to becoming an increasingly popular way to tell users to install some bit of software:-

wget https://my.web.address/projectx/installer.sh | sudo bash

Yes, it's a one liner that any fool can copy and paste. But it doesn't stop it being dumb.

villasenor commented 5 years ago

The fork that @haasosaurus has worked immediately for me with a Gnome 3 Terminal / Ubuntu 18.04 setup. Are we waiting for a PR at this point @brennanfee?

ryanoasis commented 5 years ago

Thanks all. Getting back up to speed on things

mg979 commented 5 years ago

All ttf fonts from 2.0.0 are broken in Windows (they don't show up with :set guifont=*). otf fonts work.

brennanfee commented 5 years ago

@villasenor I don't have a pending PR for this. However, I can report that I have verified the fork and patch that @haasosaurus created and the fonts work on windows for the console and various editors. @mg979 I was also able to verify that the fonts show up in gVim (on windows) when using :set guifont=*

ryanoasis commented 5 years ago

Thanks @brennanfee and @mg979

mafuba commented 5 years ago

Any update here? Really looking forward to this fix.

Jaykul commented 5 years ago

Anything we can do to get this released? Could be lots of interest in NerdFonts after the demos of the new Windows Terminal at \Build\ conf this week 😉

ryanoasis commented 5 years ago

The only thing blocking is me (https://github.com/ryanoasis/nerd-fonts/pull/283#issuecomment-480559848) testing out the #283 PR specifically the possible issue that https://github.com/ryanoasis/nerd-fonts/pull/283#issuecomment-465654029 brings up. If someone else wanted to test out the issue brought up and either fix it or be unable to replicate then I'd be inclined to merge.

Perhaps we could even just merge knowing the side effect. I am torn.

I won't be able to do much on the project until June unfortunately. Thanks for the patience

Jaykul commented 5 years ago

The actual built fonts in from regen-mono-font-fix/patched-fonts seem to have some issues with ligatures. I'm getting this: image

krokofant commented 5 years ago

@ryanoasis Merge it, seems weird to wait so long to fix something that is broken. If it introduces another bug then let's have at it.

BlueDrink9 commented 5 years ago

It does seem like this is preventing many programs from recognising the fonts as usable, which affects a lot of people hugely. The blocking bug only affects those that use ligatures/diacritics, and even then they can still use the rest of the font. Utilitarianism suggests merge

ryanoasis commented 5 years ago

283 has been merged, sorry for the wait. Let's move forward :smile:

damnskippy commented 5 years ago

@ryanoasis is there a way to download patched fonts with this fix? Thank you.

ryanoasis commented 5 years ago

@damnskippy Not at the moment. We need to run the rebuild script to re-patch all the fonts (takes a few hours). This isn't an issue but I'd like to batch several source font changes in too (since we are rebuilding anyway to avoid having to rebuild the source fonts for each change). E.g. #289 will likely be done before re-patching everything. Thanks

errantepiphany commented 5 years ago

Hi @ryanoasis . I'm sorry to bug you, as I'm sure you're very busy. But may I please ask when you might be able to run the rebuild script to re-patch all the fonts, now that https://github.com/ryanoasis/nerd-fonts/pull/283 has been merged? Even if the fix for https://github.com/ryanoasis/nerd-fonts/issues/289 is not ready yet, I think getting re-patched fonts out sooner will help a lot of people. Thank you very much - we appreciate it!

ryanoasis commented 5 years ago

@errantepiphany No worries, I am going to try to push out 2.1.0 release this month, so I will be re-patching all the fonts at least once if not multiple times until things appear to be correct. Thanks!

edit Most of the tasks in 2.1.0 are actually done or just pending rebuild... https://github.com/ryanoasis/nerd-fonts/milestone/19

errantepiphany commented 5 years ago

@ryanoasis Awesome news - thank you!

BlueDrink9 commented 4 years ago

Hi Ryan, would you mind giving a status update here please?

ryanoasis commented 4 years ago

@BlueDrink9 I am updating the changelog for 2.1.0 as I type this

github-actions[bot] commented 1 year ago

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.