search

ryanoasis / nerd-fonts

Iconic font aggregator, collection, & patcher. 3,600+ icons, 50+ patched fonts: Hack, Source Code Pro, more. Glyph collections: Font Awesome, Material Design Icons, Octicons, & more
https://NerdFonts.com
Other
54.81k stars 3.65k forks source link

"FuraCode" bugged in Windows Terminal #456

Closed privacyguy123 closed 1 year ago

privacyguy123 commented 4 years ago

I've posted the bug over there too - not sure if this is a font issue or Terminal issue anymore.

What I can't get my head round is these fonts looking totally different as well? Aren't they the same font essentially? I think Fura looks a lot more pleasing to the eyes.

image

marblewraith commented 4 years ago

Doesn't that depend on how the font is being rendered? For example if it's using direct write, also what kind of aliasing method is being used if any?

privacyguy123 commented 4 years ago

As far as I understood, the 2 fonts are based on the same thing (FiraCode) so what makes them look so different?

paulorsjr commented 4 years ago

First the ligatures, FiraCode NF draws them correctly:

image

FuraCode NF does not:

image

Then, the font appearance as a whole, FiraCode NF:

image

FuraCode NF: image

These snips were taken using the same default rendering method in Windows Terminals.

privacyguy123 commented 4 years ago

This is the exact bug I've reported over on the Windows Terminal Github - they are saying it's an issue on their end and not nerdfonts ... however, this doesn't explain how different these 2 fonts look, I'm not understanding why?

privacyguy123 commented 4 years ago

Repatching my own Fira Code file with the font-patcher fixed this visual bug for me.

Luiz-Monad commented 1 year ago

I have this same problem image

Version: FiraCode Retina 6.002

Affected: Windows Notepad 11.2209.6.0 Microsoft Visual Studio Community 2022 (64-bit) Version 17.2.4 VsCode Version: 1.73.1 Windows Terminal 1.16.2642

Finii commented 1 year ago

so what makes them look so different?

First the ligatures, FiraCode NF draws them correctly:

Well, Fira had a RFN some years back. So the patched font needed to change the name to Fura. Then the RFN had been dropped from the license.

I believe I remember that we had both (Fira NF and Fura NF) in the repo because the old fonts were not removed on an update. There is no Fura anymore since some time.

I have this same problem

I guess @Luiz-Monad means the == ligature? There were a lot fixes meanwhile, I guess that is fixed. Please try the new release 3.0.0. Please raise a new Issue if the problem persists.

image On my machine :grimacing:

github-actions[bot] commented 1 year ago

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.