search

ryanoasis / nerd-fonts

Iconic font aggregator, collection, & patcher. 3,600+ icons, 50+ patched fonts: Hack, Source Code Pro, more. Glyph collections: Font Awesome, Material Design Icons, Octicons, & more
https://NerdFonts.com
Other
54.89k stars 3.65k forks source link

Wrong letter space after patching Korean font #522

Closed dhnam closed 1 year ago

dhnam commented 4 years ago

🎯 Subject of the issue

Patched D2Coding font with patcher in Windows 10. When patched, letter space of Korean charactors are getting weird. Screenshot is attached in 'optional'.

🔧 Your Setup

★ Optional

d2-before This is what originally looks like; d2-after This is how it looks like after patch. And if I patch it in single-width, it looks like: d2-mono

Not sure it is same with other fullwidth characters(like Chinese or Japanese).

dhnam commented 4 years ago

Looks like it is own problem of FontForge. I opened ttf file of D2Coding and directly made font out of it, and it gave me same problem.

Finii commented 1 year ago

Maybe this can be solved by patching with --variable-width-glyphs. But the patched font then does probably not work in 'all' terminals anymore.

Closing this now. If you still have problems, reopen. I would need a link to the problematic font for testing in that case.

kimwonj77 commented 1 year ago

I have same issue. With same font, both with/without --variable-width-glyphs, both mono and non-mono. Original font is on https://github.com/naver/d2codingfont/releases/tag/VER1.3.2 Patched font is without --variable-width-glyphs and with --variable-width-glyphs

Build script is here: https://github.com/kimwonj77/d2coding-nerdfonts/blob/master/build.sh

Also, I'm not a original author of this issue. So I ping you, @Finii. Sorry about this.

Finii commented 1 year ago

@kimwonj77 Can you show an image were I can see the problem? If it contains Korean text it would be good to have the text also as text in the comment so that I can try it out.

dhnam commented 1 year ago

Original author here.

As far as I remember (It has been three years since I found this issue) it was problem of D2Coding font.

As said I exported D2Coding directly from FontForge, but not only that, but I also tried doing same thing with FontLab and python library (as far as remember, as said), and same thing happened.

(I also uploaded same issue at https://github.com/naver/d2codingfont/issues/84 too, which shows attempt to open and re-export the font cause total breakdown of what is written in Korean.)

Never tested with other Korean-based font, but guess it won't break with other fonts. (Guess it's worth try.)

Guess it's better ping @kimwonj77 . Sorry if this bothered you.

kimwonj77 commented 1 year ago

First, It's same as original author's image. 다람쥐 헌 쳇바퀴에 타고파.

ApplicationFrameHost_VKgjpl39zp mono on windows 11 settings.

ApplicationFrameHost_Jai9iucMXz double width on windows 11 settings. but...

Notepad_mb12W9fgo8 it's still broken on notepad.

Finii commented 1 year ago

Thank you. I believe I see the problem now. Trying to fix...

Finii commented 1 year ago

다람쥐 헌 쳇바퀴에 타고파 = b2e4 b78c c950 20 d5cc 20 ccc7 bc14 d034 c5d0 20 d0c0 ace0 d30c

Choose for research

image

Looks ok, width is maintained.

Hmm, testing in tilix

image

Looks ok. Maybe it is a Windows problem. (Comment will be continued on Windows box)

Finii commented 1 year ago

Looks ok in windows (so far)

grafik

Windows Terminal

grafik

grafik

Looks good.

Ah, you use notepad, lets see

grafik

Ah!

grafik

Looks good in writer...

So this is a wordpad notepad problem?

Edit: Mixed note- and wordpad 🙄

Finii commented 1 year ago

Original font looks good in notepad

grafik

kimwonj77 commented 1 year ago

It's bit difficult to explain, But seem like the rendering method of notepad, and some other programs are using old-school character render system. and it causes the issue. (And also, it only happens on korean character. not english.)

It's also same on fontview.exe with korean locale (fontview.exe' is locked by windows locale.). Like og author's image.

Also Eclipse image

Finii commented 1 year ago

I found the problem.

The issue is with the OS/2 xAvgCharWidth data in the font. (OS/2 is the name of one data table within a open type font (for example .ttf))

Unfortunately there are multiple bugs here in parallel so I do not really know how to proceed here.

Possible actions

I do not really like to add options to font-patcher if it can be avoided.

Are there other - possibly Korean - fonts affected or is that only D2Coding?

[1] https://learn.microsoft.com/en-us/typography/opentype/spec/os2#xavgcharwidth [2] https://developer.apple.com/fonts/TrueType-Reference-Manual/RM06/Chap6OS2.html

Fix snippet

diff --git a/font-patcher b/font-patcher
index 01e144e4c..a82e6f8c5 100755
--- a/font-patcher
+++ b/font-patcher
@@ -135,6 +135,7 @@ class TableHEADWriter:
             positions = {'checksumAdjustment': 2+2+4,
                          'flags': 2+2+4+4+4,
                          'lowestRecPPEM': 2+2+4+4+4+2+2+8+8+2+2+2+2+2,
+                         'avgWidth': 2,
                 }
             where = self.tab_offset + positions[where]
         self.f.seek(where)
@@ -421,6 +422,10 @@ class font_patcher:
                 for idx in range(source_font.num_fonts):
                     if not self.args.quiet:
                         print("{}: Tweaking {}/{}".format(projectName, idx + 1, source_font.num_fonts))
+                    source_font.find_table([b'OS/2'], idx)
+                    dest_font.find_table([b'OS/2'], idx)
+                    dest_font.putshort(source_font.getshort('avgWidth'), 'avgWidth')
+                    dest_font.reset_table_checksum()
                     source_font.find_head_table(idx)
                     dest_font.find_head_table(idx)
                     if source_font.flags & 0x08 == 0 and dest_font.flags & 0x08 != 0:

This does not calculate the version 2 number but just copies over the value from the source font. Which would be ok if we just want to fix D2Coding I guess. The code is minimal, just what I used to prove that this is the issue's cause.

Edit: Typo fix

Finii commented 1 year ago

fontforge back-links

Finii commented 1 year ago

Even Glyphs3 does not allow to produce notepad compatible fonts...

https://forum.glyphsapp.com/t/font-custom-parameters/1174

kimwonj77 commented 1 year ago

Maybe the Nanum-font series has this problem too. (D2Coding is one of them). But I'm not tested. https://hangeul.naver.com/font/nanum - All "Nanum" series fonts (for basic usage.) (in Korean) https://github.com/naver/nanumfont - "Nanum Gothic Coding", an old version of D2 coding.

Finii commented 1 year ago

If you use font-patcher in-parens-version 3.7.0 or later you can now add --xavgcharwidth to copy the value and create a font usable in notepad:

image

For your (@kimwonj77) project: If you specify --complete you do not need to add all these specific glyphs sets, so it would be sufficient to

--complete --makegroups --xavgcharwidth --also-windows --careful --no-progressbars
kimwonj77 commented 1 year ago

Thank you for response! Now I can be happy with Korean font! D2Coding is (if I remember correctly) one and only Korean-Code font since the release...

Also, thank you for reviewing my script! I added it for test just in case.

dhnam commented 1 year ago

Never expected this issue to be corrected! I just gave up using D2Coding patched with nerd font. But looks like I also can be happy with Korean font!

Huge thanks to both of you, Finni and Kimwonj77!

github-actions[bot] commented 1 year ago

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.