ryanoasis / nerd-fonts

Iconic font aggregator, collection, & patcher. 3,600+ icons, 50+ patched fonts: Hack, Source Code Pro, more. Glyph collections: Font Awesome, Material Design Icons, Octicons, & more
https://NerdFonts.com
Other
55.15k stars 3.65k forks source link

Missing ligatures after patching Iosevka #591

Closed mfocko closed 2 years ago

mfocko commented 3 years ago

🎯 Subject of the issue

After patching Iosevka 5.0.5 (recently released), I noticed I'm missing ligatures in the fonts (I've patched both Iosevka and Iosevka Curly Slab variant), but they're not missing in the Extended variant of the font. I simply thought it's the problem with the font. However I've also noticed no stylistic sets in those problematic fonts, so it might be a problem with the patcher.

Issue at Iosevka repository: https://github.com/be5invis/Iosevka/issues/910

🔧 Your Setup

★ Optional

mfocko commented 3 years ago

Seems to be fine with 5.0.6 release, not sure what is going on :D

yetone commented 2 years ago

same problems

nerd font version:

image

original version:

image
Finii commented 2 years ago

Did you self patch, or use font from here? Can you give links where downloaded exactly? And copy and paste the glyphs as text please, so I can try.

mfocko commented 2 years ago

I self patch, using latest latest nerd-fonts and TTF Iosevka package, e.g. https://github.com/be5invis/Iosevka/releases/download/v15.1.0/ttf-iosevka-15.1.0.zip

I use Term variant lately, so not sure if it's still broken or not, since I stopped patching the fonts.

mfocko commented 2 years ago

yeah, still broken, even with Term variant

Finii commented 2 years ago

When you self patch, do you get the 16 bit warning from fontforge? Of course you use an up to date fontforge (i.e. after my fix in fontforge), which probably means self building fontforge or using fontforge release March 2022?

If the ligatures are still missing when you use the bugfixed fontforge I can have a look at font-patcher, but the likelihood is slim.

Finii commented 2 years ago

See

Finii commented 2 years ago

See hints in the bottom of #742

github-actions[bot] commented 1 year ago

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.