ryanoasis / nerd-fonts

Iconic font aggregator, collection, & patcher. 3,600+ icons, 50+ patched fonts: Hack, Source Code Pro, more. Glyph collections: Font Awesome, Material Design Icons, Octicons, & more
https://NerdFonts.com
Other
54.89k stars 3.65k forks source link

font-patcher: Vertically centered glyphs not really centered ('valign' = 'c') #592

Closed Finii closed 1 year ago

Finii commented 3 years ago

🗹 Requirements

🎯 Vertical alignment slightly off with some fonts

A lot (most) of the glyphs added are vertically centered ('valign' = 'c' in font-patcher). With some source fonts the alignment is not very good and for example (because of its symmetry it makes the behavior most notable) the Ubuntu logo  (0xF31B) is above or below the 'perceived' middle. The middle is usually perceived as the vertical center of the square brackets [, the height of the minus -, the intersection of the lines of capital X, or the left tip of less then <

The issue has already been researched and a pull request has been prepared (link to PR coming here).

🔧 Your Setup

★ Optional

As example the screenshot with Gnome terminal and CaskaydiaCove Nerd Font Mono Regular 42: image

(All vertically centered new glyphs are too high, e.g. 'git branch' 0xE0A0, 'rain at night' 0xF024.)

Expected would be: image

More images of all the fonts will be shown in the MR.

github-actions[bot] commented 1 year ago

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.