ryanoasis / nerd-fonts

Iconic font aggregator, collection, & patcher. 3,600+ icons, 50+ patched fonts: Hack, Source Code Pro, more. Glyph collections: Font Awesome, Material Design Icons, Octicons, & more
https://NerdFonts.com
Other
54.08k stars 3.63k forks source link

Terminus distorted glyphs after patch #86

Closed lcorsini closed 2 years ago

lcorsini commented 8 years ago

Hello, Since Terminus doesn't seem to be provided because of some issues in patching the original bdf files, I tried to use the script to patch this TTF version http://files.ax86.net/terminus-ttf/ which includes at least the basic powerline symbols the patch works, but the font gets very distorted as you can see in the screenshot (this font is very clear at 12points without antialiasing)

font

any ideas on why this happens?

ryanoasis commented 8 years ago

@lcorsini Thanks for the details. Nothing particular is coming to my mind right now but I will try to take a look. :smile:

lcorsini commented 8 years ago

Thanks, Maybe if there is no particular licensing problem you could include this TTF in your distribution (I use Terminus a Lot, it's one of the best in readability, and this TTF works cross platform even on windows and osx)

ryanoasis commented 8 years ago

Yes if the license is fine it would be better to just try to patch the TTF like you have done 😄

As for the issues you mentioned I just haven't gotten around to looking into it yet 😞

ryanoasis commented 7 years ago

@lcorsini Can you give more info on the screenshot you provided? What system, editor etc?

This appears to be a problem with the ttf file not the patching. I was able to replicate the very distorted characters without antialiasing turned on, on the original ttf and the patched ttf file.

Another option would be to patch the bitmap fonts but this would require more work, something similar to how https://bitbucket.org/ZyX_I/bitmap-font-patcher works

lcorsini commented 7 years ago

Ok, in the meantime I moved away from that setup, it was on windows, the editor is vim, and probably this was under putty The Terminus font is better without antialias and on 12pt that's why I was using it like that

ryanoasis commented 7 years ago

@lcorsini Thanks for the details. Yeah I can see that being a bitmap font that would be the typical usage. I am marking this as 'future' as I believe it will take a good amount of effort to be able to patch the bitmap version of this font and I think most people will have antialiasing on.

quinn-brittain commented 5 years ago

I have the same problem with patched Terminus TTF it looks all distorted. No matter if I download the pre-patched font or if I patch it myself (using the Terminus TTF that displays correctly).

Unpatched font: Screen Shot 2019-03-28 at 11 08 17 PM

Patched font: Screen Shot 2019-03-28 at 10 55 47 PM

System Details: macOS 10.14.3 iTerm 2 build 3.2.8 zsh (oh-my-zsh powerlevel9k theme) Terminus TTF 16pt (I've used the unpatched font and it looks fine at this size) Anti-aliasing disable for both patched and unpatched

DoctorKnowsBetter commented 2 years ago

I fixed this crap :) https://github.com/DoctorKnowsBetter/TerminessNerdFont-FixBlur

Slabity commented 2 years ago

Nice! Did you make a fix for the font patcher itself or did you end up fixing it manually? Can you get the change pulled into this repo?

DoctorKnowsBetter commented 2 years ago

I did it manually. The script (font-patcher) does not transfer bitmap layers, I had to create and transfer all bitmap layers from the original Terminus.

Finii commented 2 years ago

Nice! :+1: @DoctorKnowsBetter

I never ever bothered about bitmap fonts :-}

Finii commented 2 years ago

@DoctorKnowsBetter Which option did you use on generate? image

Finii commented 2 years ago

Fonts containing bitmaps:

Examining 601 font files
bitmap (11,) (gohufont-11)
bitmap (14,) (gohufont-14)
bitmap (11,) (gohufont-uni-11)
bitmap (14,) (gohufont-uni-14)
bitmap (7, 9, 10, 12, 14, 18, 24) (ProFontIIx)
bitmap (12, 14, 16, 18, 20, 22, 24, 28, 32) (TerminusTTF-Bold Italic-4.40.1)
bitmap (12, 14, 16, 18, 20, 22, 24, 28, 32) (TerminusTTF-Bold-4.40.1)
bitmap (12, 14, 16, 18, 20, 22, 24, 28, 32) (TerminusTTF-Italic-4.40.1)
bitmap (12, 14, 16, 18, 20, 22, 24, 28, 32) (TerminusTTF-4.40.1)
Finii commented 2 years ago

Maybe you could try #939 @DoctorKnowsBetter @Slabity ?

DoctorKnowsBetter commented 2 years ago

@Finii This options: 2022-09-23_13-00

Finii commented 2 years ago

@DoctorKnowsBetter Thank you. That is what I implemented in #939.

Finii commented 2 years ago

Seems to work :-)

Previously:

image

With this PR applied...:

image

Now it looks equal.

Finii commented 2 years ago

Well, I see nothing with my terminal tilix (which probably can do nothing with bitmap fonts).

But here, with Libre writer:

all

But someone should test that with a terminal :grimacing:

DoctorKnowsBetter commented 2 years ago

@Finii Yes, there is such a problem, some terminals do not see bitmap layers in TTF fonts. Terminals that I use and tested by me (fonts are displayed correctly):

Finii commented 2 years ago

So the fix works? Then i will merge?

DoctorKnowsBetter commented 2 years ago

@Finii I guess so. If someone does not display fonts correctly in the terminal, then the issue should be resolved with the developers of this terminal. Most terminals will not have these problems.

Finii commented 2 years ago

Great! Thanks for testing and for showing your fix! Without it we would not have the PR. :heart:

github-actions[bot] commented 1 year ago

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.