search

ryanoasis / nerd-fonts

Iconic font aggregator, collection, & patcher. 3,600+ icons, 50+ patched fonts: Hack, Source Code Pro, more. Glyph collections: Font Awesome, Material Design Icons, Octicons, & more
https://NerdFonts.com
Other
53.88k stars 3.63k forks source link

Vertical alignment wrong? #877

Closed Finii closed 1 year ago

Finii commented 2 years ago

Discussed in https://github.com/ryanoasis/nerd-fonts/discussions/874

Originally posted by **augustocdias** August 10, 2022 I'm trying to patch codicons into Firacode and I'm having some issues. It is adding a bottom padding to the glyphs. ![image](https://user-images.githubusercontent.com/1080789/183072165-a592e113-ab50-4284-aa78-2ab6f31b0e8d.png) Is there a flag or a setting I can set to adjust this and fix it? This is how I patched it: ``` fontforge -script font-patcher /Users/augusto/Library/Fonts/Fira\ Code\ Retina\ Nerd\ Font\ Complete\ Mono.otf --custom codicon.ttf ``` I installed the font from brew.

Additional info:

Can be reproduced with current master font-patcher, using v2.1.0 Fira Code NF and https://github.com/microsoft/vscode-codicons/blob/main/dist/codicon.ttf

Finii commented 1 year ago

Hmm, this is 'as intended':

image

There is no scaling for '--custom' and no valign.

And this is the case since ... the invention of --custom

image

So this might be unexpected, but someone choose it this way specifically. Of course we could discuss to change it, but for now I see no need.

github-actions[bot] commented 1 year ago

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.