search

ryanoasis / vim-devicons

Adds file type icons to Vim plugins such as: NERDTree, vim-airline, CtrlP, unite, Denite, lightline, vim-startify and many more
MIT License
5.61k stars 263 forks source link

Vim become slow after update to 0.7.0 #127

Closed zaferot closed 8 years ago

zaferot commented 8 years ago

Hi All. After the upgrade to 0.7.0 my Vim is extremely lagging and there are strange visual artifacts. Please see that attached screenshot. I had to disable the plugin for now. My vimrc is in my profile. I use patched Meslo LG S (patched via font-patcher). Please let me know if you need any additional information. Thanks! snapshot1

her commented 8 years ago

Also getting this +1

https://gyazo.com/8f8104e79428bfda9cdd25673e514443

ryanoasis commented 8 years ago

Eek! :open_mouth:

Yep I have questions:

@zaferot Ah sorry I see you said you have it in your profile. I'll check it out.

Thanks both of you for info here.

I will try to replicate today. Cheers

zaferot commented 8 years ago

HI @ryanoasis,

What OS? OS X?

Arch Linux

GUI or terminal vim?

Terminal

Did the problem immediately go away upon disabling devicons?

Yes. ( but Vim has to be restarted).

was devicons the only plugin updated?

There were two or three plugins updated.

with the issue occurring do you have anything in the output of :messages?

Now, when the plugin is enabled the issue is constant. It's not periodic or temporary. :messages output gives me Messages maintainer: Bram Moolenaar <Bram@vim.org>.

her commented 8 years ago

OS X, terminal vim -v 7.4.922

Did the problem immediately go away upon disabling devicons? was devicons the only plugin updated?

yes 😭

with the issue occurring do you have anything in the output of :messages?

I had to disable the plugin before troubleshooting because it broke so hard 🤕

can you give me a list of your plugins or a link to your vimrc?

My current plugin list:

'altercation/vim-colors-solarized' 'scrooloose/nerdtree' 'tpope/vim-fugitive' 'airblade/vim-gitgutter' 'scrooloose/syntastic' 'junegunn/goyo.vim' 'Valloric/YouCompleteMe' 'junegunn/vim-emoji' 'Yggdroot/indentLine' 'itchyny/lightline.vim'

Hope that helps 😊

epilande commented 8 years ago

Also noticed my vim got super laggy after updating to 0.7.0. Once I disabled vim-devicons, the lag went away.

I'm using OSX, iTerm, & Neovim.

ryanoasis commented 8 years ago

Here is the fix if anyone needs it ASAP: https://gist.github.com/ryanoasis/7be48afae7c700d1a465 :tada:

^ caches the system call, it was my fault that I didn't realize that new system call in the PR would be executed SO often

I will push something tomorrow :sleeping:

her commented 8 years ago

thanks @ryanoasis! good stuff 🤓👏🏻