ryanoasis / vim-devicons

Adds file type icons to Vim plugins such as: NERDTree, vim-airline, CtrlP, unite, Denite, lightline, vim-startify and many more
MIT License
5.64k stars 265 forks source link

After Plug Update, all icons became the same color in NerdTree #330

Closed vando026 closed 4 years ago

vando026 commented 4 years ago

Between commits 58e57b6 and 0b6a7bd, my custom icon colors in NerdTree changed to all the same color.

Commit 58e57b6

Commit_58e57b6

Commit 0b6a7bd

Commit_0b6a7bd

All else stays the same and this behaviour is obtained by toggling the commits in my vimrc.

Toggle

Required Info

Optional Info

taq commented 4 years ago

I'm also facing the same situation. I was searching for "color" here and found this issue.

Menn1s commented 4 years ago

Hi, I've been having issues getting any highlighting to work on only the glyphs. I could only get it to apply to the entire filename and the glyph (but when highlighting does work, it would add brackets). Could I see the section of your vimrc that adds color? I could not get any of the other instructions to work properly

tiagofneto commented 4 years ago

I also have the same problem, currently using commit 58e57b6.

taq commented 4 years ago

Em qui., 14 de mai. de 2020 às 13:52, IK notifications@github.com escreveu:

Thanks for report. How about this patch?

Seems the patch worked!

taq commented 4 years ago

Uh, where is the @kazukazuinaina content with the patch I just got on email?

get-me-power commented 4 years ago

@taq

In that patch, the following bug was reproduced, so I delete it. Sorry for the confusion.

https://github.com/ryanoasis/vim-devicons/issues/278

taq commented 4 years ago

Oh, ok, but for this issue here, it solved the problem. But, a file called [id].js ? I'd rather fix my colors than think in finding file names with brackets. :-)

vando026 commented 4 years ago

Hi Just following up on this, the person that made the commit at 0b6a7bd is below

0b6a7bd - Phil Runninger, 4 weeks ago : Ensure only the brackets around the flags are concealed.

Shouldnt we try to contact him?

her commented 4 years ago

@vando026 are you using the tiagofumo/vim-nerdtree-syntax-highlight plugin?

vando026 commented 4 years ago

Yes I am, and I have it loaded last straight after ryanoasis/vim-devicons.

Ninlives commented 4 years ago

Oh, ok, but for this issue here, it solved the problem. But, a file called [id].js ? I'd rather fix my colors than think in finding file names with brackets. :-)

Do you have a copy of that patch? Thanks :)

polyzen commented 4 years ago

@Ninlives, see #332.

her commented 4 years ago

Hey y'all, we closed this PR as it would introduce regressions with conceal of files where the names have square brackets in them, e.g. [id].js

For an interim highlighting solution for DevIcons see https://github.com/her/synicons.vim

her commented 4 years ago

this is now fixed in https://github.com/tiagofumo/vim-nerdtree-syntax-highlight/commit/bb0a941f01a619a1dc2880795b39bbbd4ff9f247

get-me-power commented 4 years ago

@her

Thanks!

taq commented 4 years ago

@her I just installed your plugin (removing the patched @tiagofumo one) but now my NerdTree is back to no colors again. :-(

taq commented 4 years ago

Weird stuff. I was using the patched devicons, just removed it and back to @tiagofumo plugin, removing everything and installing again with fresh copies seems to solved my problem.

vando026 commented 4 years ago

@her thanks this worked for me too using @tiagofumo plugin and settings.

her commented 4 years ago

That’s great y’all! Glad it’s back to normal 👍

SubhamBurnwal commented 3 years ago

Okay,,, so I tried to follow this discussion and its confused me even more. All my icons are having the same color as was the case with all of you. I have the latest versions of everything installed since it was just yesterday I called PlugUpdate. Do the following settings in .vimrc affect something?

set guifont=MesloLGLDZ\ Nerd\ Font\ Regular\ 11 

Plug 'vim-airline/vim-airline'                                                                                     
Plug 'vim-airline/vim-airline-themes'
    let g:airline#extensions#tabline#enabled = 1
    let g:airline_powerline_fonts = 1
Plug 'ryanoasis/vim-devicons'

Also, can you just list the solution in steps? Screenshot from 2021-01-18 20-38-41

BenHerbst commented 2 years ago

I also have the same issue

ensia96 commented 2 years ago

I have same problem after updating nvim to 0.8.0 (I also updated nvim plugins too)

sforli commented 1 year ago

The problem is still here, I've tried calling the plugin before and after tiagofumo's syntax highlight, and the commit at the beginning of this issue. Did I miss something?