search

ryanolf / node-sonos-nfc

Access your streaming music through physical NFC tokens, like putting on a CD or record. Great for children and adult aesthetics.
MIT License
36 stars 14 forks source link

Make playback options reset configurable #7

Closed mattijsbliek closed 2 years ago

mattijsbliek commented 3 years ago

Finally an actual feature 😅 This PR makes it configurable whether to reset playback options when new music is queued.

It's build on top of the Add logger PR, so my suggestion would be to review that one first.

Important bits

ryanolf commented 3 years ago

I'll have to check on the parallel reset commands. I recall doing them with a delay between them in order to make sure they were processed correctly by the controller. Maybe a bug on the sonos side?

On Mon, Aug 9, 2021 at 4:23 AM Mattijs Bliek @.***> wrote:

Finally an actual feature 😅 This PR makes it configurable whether to reset playback options when new music is queued.

It's build on top of the Add logger https://github.com/ryanolf/node-sonos-nfc/pull/6 PR, so my suggestion would be to review that one first.

Important bits

  • Extract the resetting of playback options to a separate function, so it can be independently tested and the process_sonos_command becomes easier to follow.
  • Fire reset commands are in parallel via Promise.all. I don't know if this actually works since I don't yet have a hardware setup to test with.
  • Keep the responsibility of which command should reset playback options in process_sonos_command.
  • Extract get_sonos_url so it can be used everywhere.

You can view, comment on, or merge this pull request online at:

https://github.com/ryanolf/node-sonos-nfc/pull/7 Commit Summary

  • Add logger.
  • Fix config class not working in tests.
  • Add supported log levels to README.
  • Make playback options reset configurable.
  • Remove redundant function argument.
  • Strict checking of reset_playback_options_on_queue config option.

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ryanolf/node-sonos-nfc/pull/7, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJSBSQFUZHLP6PEI2LZITDT363DJANCNFSM5BZZ6GFA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .