ryanongwx / pe

0 stars 0 forks source link

View 0 showing wrong output #8

Open ryanongwx opened 10 months ago

ryanongwx commented 10 months ago

Screenshot 2023-11-17 at 5.07.53 PM.png

Screenshot 2023-11-17 at 5.08.32 PM.png

View 0 is a positive integer and should be understood and the output should be out of bounds instead

nus-pe-script commented 10 months ago

Team's Response

This issue is a duplicate of Issue #1708, which highlights the point that error messages for 0 indices give the wrong error message in the output box.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Delete 0 showing wrong output

Screenshot 2023-11-17 at 5.09.32 PM.png

delete 0 is a positive integer and should be understood, Instead the out of bounds output should be shown instead Screenshot 2023-11-17 at 5.10.36 PM.png


[original: nus-cs2103-AY2324S1/pe-interim#1329] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for taking the time to feedback. However, one can be very technical about the definition of zero and whether it is included in the set of positive integers. Based on the CS1231S Discrete Structure lecture 5 Set Theory slide 9, 0 for all intents and purposes is not considered as part of the set of positive integers.

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]