search

ryanpcmcquen / obsidian-focus-mode

Add focus mode to Obsidian.
Mozilla Public License 2.0
68 stars 7 forks source link

Using ctrl + alt + z to get out of super focus mode opens side bars that had been collapsed #29

Closed Hunanbean closed 2 years ago

Hunanbean commented 2 years ago

Using ctrl + alt + z to get out of super focus mode opens die bars that had been collapsed

ryanpcmcquen commented 2 years ago

Yep, that's expected behavior.

Hunanbean commented 2 years ago

Perhaps you need to re-examine your design.

ryanpcmcquen commented 2 years ago

When exiting focus mode, the side bar states are restored from before focus mode, this is the intended design and was also requested by other users.

ryanpcmcquen commented 2 years ago

https://github.com/ryanpcmcquen/obsidian-focus-mode/issues/9

Hunanbean commented 2 years ago

The reason for the report is that "Using ctrl + alt + z to get out of super focus mode opens side bars that had been collapsed" meaning, it is not the state that it went in to focus mode with. It has uncollapsed a side bar that was manually collapsed.

ryanpcmcquen commented 2 years ago

I cannot reproduce that behavior. Do you have other plugins enabled?

Hunanbean commented 2 years ago

Tested with no 3rd party plugins. Problem persists. For a test, you can drag the graph view into the right side panel to create a valid window there. Collapse the right side panel using the arrow provided.

KB shortcut to SFM, keyboard shortcut ctrl+alt+z notice the right side panel is open now, when you left it closed before entering SFM

On Thu, Jan 13, 2022 at 12:19 PM Ryan McQuen @.***> wrote:

I cannot reproduce that behavior. Do you have other plugins enabled?

— Reply to this email directly, view it on GitHub https://github.com/ryanpcmcquen/obsidian-focus-mode/issues/29#issuecomment-1012484736, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNVR7HXKLEVVNSCW6S3ZUTUV4XUTANCNFSM5L4U73UA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

pbienst commented 2 years ago

I can confirm this bug: entering superfocus mode through keyboard shortcut, then exiting it by clicking the icon in the left ribbon, opens the tag panel even though it was closed before.

Perhaps this bug report should be reopened?

ryanpcmcquen commented 2 years ago

I can confirm this bug: entering superfocus mode through keyboard shortcut, then exiting it by clicking the icon in the left ribbon, opens the tag panel even though it was closed before.

Perhaps this bug report should be reopened?

What plugins are you running?

pbienst commented 2 years ago

The problem occurs even when no other plugins are running.

ryanpcmcquen commented 2 years ago

The problem occurs even when no other plugins are running.

Can you record a video?

pbienst commented 2 years ago

There you go: https://www.dropbox.com/s/afdq7ga1s7nmuz0/2022-05-06%2020-59-02.mkv?dl=0

ryanpcmcquen commented 2 years ago

There you go: https://www.dropbox.com/s/afdq7ga1s7nmuz0/2022-05-06%2020-59-02.mkv?dl=0

Is this a custom theme? I still can't reproduce.

pbienst commented 2 years ago

Changing to the default theme does not help...

ryanpcmcquen commented 2 years ago

Changing to the default theme does not help...

I'll try to do some more testing this weekend.

ryanpcmcquen commented 2 years ago

I reproduced this today, working on a fix!

ryanpcmcquen commented 2 years ago

Fixed! https://github.com/ryanpcmcquen/obsidian-focus-mode/releases/tag/1.8.3

pbienst commented 2 years ago

Works indeed! Thanks a lot!