ryanpcmcquen / obsidian-focus-mode

Add focus mode to Obsidian.
Mozilla Public License 2.0
68 stars 7 forks source link

Super focus doesn't(?) work in Obsidian 1.0.3 #38

Closed danieltomasz closed 1 year ago

danieltomasz commented 2 years ago

Superfocus make the pane that is not in focus blank, but doesn't hide it

Vault_is_just_a_local_folder_-_Obsidian_Sandbox_-_Obsidian_v1_0_3
ryanpcmcquen commented 2 years ago

Would accept a PR fixing this.

danieltomasz commented 2 years ago

I dont know if this helps but full pane focus is able to get cure leaf when in two pane view (although make it full screen instead of full window) https://github.com/Razumihin/obsidian-fullscreen-plugin

ryanpcmcquen commented 1 year ago

Will you try the latest version and let me know if you have any issues? https://github.com/ryanpcmcquen/obsidian-focus-mode/releases/tag/1.11.0

danieltomasz commented 1 year ago

Great, it works! Thank you for fixing this! The look into other plugin was useful?

Only thing I noticed is this

  1. I have view with 2 panes open image

When I superfocus on the right pane the tab bar overlap with the windows buttons, this effect doesnt happen when I focus on the left pane

image image

Also unexpected behaiour when https://github.com/NomarCub/obsidian-hide-sidebars-on-window-resize is active 1.Activate superfocus mode when the obsidian window is smaller (half of the screen)

  1. Maximalize Obsidian Window
  2. the Hide sidebars plugin attempt to add sidebar
image

Dont expect this to be fixed (I might create an issue there too), but maybe info in the readme will be useful

ryanpcmcquen commented 1 year ago

I'll look into a fix for the window button overlap. I don't use that other plugin so I'm not sure what it is doing.

ryanpcmcquen commented 1 year ago

@danieltomasz attempted to fix the window button overlap, let me know what you think: https://github.com/ryanpcmcquen/obsidian-focus-mode/releases/tag/1.11.1

danieltomasz commented 1 year ago

yes, this works fine!