ryanprior / emacs-guix-packaging

Tools for writing and maintaining Guix packages
22 stars 3 forks source link

guix-packaging-insert-input is slow #3

Closed Ambrevar closed 3 years ago

Ambrevar commented 3 years ago

Typing in the minibuffer of guix-packaging-insert-input is very slow. I believe this is because guix-packaging--list-available runs guix on every query update.

I suggest the following optimization: store the full list once with guix-packaging--map-tsv-to-plist, then query this plist in guix-packaging-insert-input completion-table-dynamic.

ryanprior commented 3 years ago

That's interesting, it's fast for me but maybe my ivy completion system is doing some caching for me. I will do some testing in a bare Emacs and get the performance to an acceptable level.

Ambrevar commented 3 years ago

I've only tested with Helm.

Ambrevar commented 3 years ago

It's blazing fast now, excellent!