ryanqq / openjpeg

Automatically exported from code.google.com/p/openjpeg
Other
0 stars 0 forks source link

convert.c is unmaintainable #264

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
Just look at convert.c to be convinced. For example have a look at issue #171 
and in particular the patch needed to clamp value returned from openjpeg. All 
formats are affected by the issue.

This means that we could have our test suite be valid for PGX output, but 
invalid for other, this feel really unconfortable.

Original issue reported on code.google.com by mathieu.malaterre on 28 Feb 2014 at 8:38

GoogleCodeExporter commented 9 years ago
I think convert.c should support pgx, raw, tiff and png. Its used only for test 
suite and give example through applications.

Original comment by savmick...@gmail.com on 6 Mar 2014 at 11:54

GoogleCodeExporter commented 9 years ago
I think that convert.c needs to be split.
IMHO, there shall be one file per image format with one helper file which deals 
with component bit depth limitations, component transform (e.g. from transform 
one line from opj_image to 8bpp interleaved RGB with clamping etc...)

We can see that all imagetoxxx share a great deal of code. The minimum effort 
needed is to get this code merged in helper functions that are used 
consistently throughout those imagetoxxx functions.

Original comment by m.darb...@gmail.com on 16 Oct 2014 at 10:05

GoogleCodeExporter commented 9 years ago
I started to split it starting at r2972 to get Issue 203 a bump.

Original comment by m.darb...@gmail.com on 20 Dec 2014 at 6:51