search

ryanqq / openjpeg

Automatically exported from code.google.com/p/openjpeg
Other
0 stars 0 forks source link

TIF: file6 does not integrate well with test suite (corrupted?) #282

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
file6 is reported as a failing test.

Original issue reported on code.google.com by mathieu.malaterre on 12 Mar 2014 at 11:22

GoogleCodeExporter commented 9 years ago 
The whole test suite is confused with input. Indeed file6.jp2 is reported as:

  44      : Sub Box: "ihdr" Image Header box
    Height               : 512
    Width                : 768
    Components           : 1
    Bits Per Component   : 12
    Signed Components    : no
    Compression Type     : wavelet
    Unknown Colourspace  : no
    Intellectual Property: no

  66      : Sub Box: "colr" Colour Specification box
    Colour Specification Method: enumerated colourspace
    Precedence   :  0
    Approximation:  1
    Colourspace  : greyscale

However:

$ tiffinfo data/baseline/conformance/jp2_6.tif
TIFFReadDirectory: Warning, Unknown field with tag 37724 (0x935c) encountered.
TIFF Directory at offset 0x8 (8)
  Subfile Type: (0 = 0x0)
  Image Width: 768 Image Length: 512
  Resolution: 72, 72 pixels/inch
  Bits/Sample: 8
  Compression Scheme: LZW
  Photometric Interpretation: RGB color
  Samples/Pixel: 3
  Rows/Strip: 3
  Planar Configuration: single image plane
  Photoshop Data: <present>, 3780 bytes
  Tag 37724: 0x41,0x64,0x6f,0x62,0x65,0x20,0x50,0x68,0x6f,0x74,0x6f,0x73,0x68,0x6f,0x70,0x20,0x44,0x6f,0x63,0x75,0x6d,0x65,0x6e,0x74,0x20,0x44,0x61,0x74,0x61,0x20,0x42,0x6c,0x6f,0x63,0x6b,0x0
  Predictor: horizontal differencing 2 (0x2)

Original comment by mathieu.malaterre on 12 Mar 2014 at 11:23

GoogleCodeExporter commented 9 years ago 
Technically openjpeg and kakadu are producing the same result:

$ kdu_expand -i data/input/conformance/file6.jp2 -o bla.kdu.rawl
$ opj_decompress -i data/input/conformance/file6.jp2 -o bla.opj.rawl
$ crc32 bla.kdu.rawl bla.opj.rawl
400ce026    bla.kdu.rawl
400ce026    bla.opj.rawl

Original comment by mathieu.malaterre on 12 Mar 2014 at 11:24

GoogleCodeExporter commented 9 years ago

Original comment by mathieu.malaterre on 12 Mar 2014 at 1:12

GoogleCodeExporter commented 9 years ago

Original comment by mathieu.malaterre on 14 Mar 2014 at 2:04

GoogleCodeExporter commented 9 years ago

Original comment by anto...@gmail.com on 24 Mar 2014 at 3:55

GoogleCodeExporter commented 9 years ago

Original comment by mathieu.malaterre on 24 Mar 2014 at 5:16

GoogleCodeExporter commented 9 years ago 
So there are actually two different problems : 
1/ reference tif file from the conformance set is wrong
2/ tif support is limited (see #322)
I leave this issue open waiting for (1) to be solved. Thomas Richter should 
provide new reference file.

Original comment by anto...@gmail.com on 31 Mar 2014 at 9:37

GoogleCodeExporter commented 9 years ago 
Reference TIF file is actually ok. 
Long story short, conformance tests have been designed assuming that the tested 
decoder output is downscaled to 8 bits and converted to sRGB before being 
compared to reference tif file.

File6 test is actually passing but the test needs to be updated by downscaling 
from 16 bits to 8 bits, and by considering only the first component of 
reference file before doing the comparison.

So it's a test issue rather than a coding issue.

Original comment by anto...@gmail.com on 3 Apr 2014 at 3:40

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r2939.

Update  issue 286

Original comment by m.darb...@gmail.com on 22 Nov 2014 at 12:03

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r2940.

Original comment by m.darb...@gmail.com on 22 Nov 2014 at 12:05

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r2941.

Original comment by m.darb...@gmail.com on 22 Nov 2014 at 12:30