ryanqq / openjpeg

Automatically exported from code.google.com/p/openjpeg
Other
0 stars 0 forks source link

Build fails on maces when building third-party libtiff #285

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
cmake -DBUILD_TESTING:BOOL=ON -DBUILD_THIRDPARTY:BOOL=ON 
-DCMAKE_OSX_ARCHITECTURES:STRING=x86_64 -DBUILD_SHARED_LIBS:bool=OFF
make

What is the expected output? What do you see instead?
Expected : Build Success
Instead : link errors with duplicated symbols

What version of the product are you using? On what operating system?
trunk r2703 , macos 10.9.2, XCode 5.1 (using Unix makefile generator => clang 
5.1) 

Please provide any additional information below.
trunk/thirdparty/libtiff/test_inline.c contains duplicated content. Removing 
the duplicated content fixes the issue.

Original issue reported on code.google.com by m.darb...@gmail.com on 12 Mar 2014 at 9:40

GoogleCodeExporter commented 9 years ago
The actual error cannot be seen on the dashboard:

http://my.cdash.org/index.php?project=OPENJPEG

could you either provide a fix (patch) and or copy/paste the error ?

Original comment by mathieu.malaterre on 14 Mar 2014 at 2:48

GoogleCodeExporter commented 9 years ago
http://my.cdash.org/buildSummary.php?buildid=580826

Fix is pretty easy,
trunk/thirdparty/libtiff/test_inline.c content is :
/* Test source lifted from /usr/share/autoconf/autoconf/c.m4 */
typedef int foo_t;
static inline foo_t static_foo(){return 0;}
foo_t foo(){return 0;}
int main(int argc, char *argv[]){return 0;}
/* Test source lifted from /usr/share/autoconf/autoconf/c.m4 */
typedef int foo_t;
static inline foo_t static_foo(){return 0;}
foo_t foo(){return 0;}
int main(int argc, char *argv[]){return 0;}

Shall only be :
/* Test source lifted from /usr/share/autoconf/autoconf/c.m4 */
typedef int foo_t;
static inline foo_t static_foo(){return 0;}
foo_t foo(){return 0;}
int main(int argc, char *argv[]){return 0;}

Original comment by m.darb...@gmail.com on 14 Mar 2014 at 3:08

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r2746.

Original comment by mathieu.malaterre on 14 Mar 2014 at 3:10