search

ryanrightmer / lis3mdl

A platform agnostic driver to interface with the LIS3MDL (3-axis magnetic sensor)
Apache License 2.0
3 stars 6 forks source link

Allow specifying I2C address #3

Closed nnarain closed 2 years ago

justacec commented 2 years ago

@ryanrightmer I was going to go ahead and merge this into master and then close the other PR unless you had any reservations. Did not get any feedback on the other PR yet. Thoughts?

nnarain commented 2 years ago

I don't think I realized at the time I made this MR there was another one addressing the same thing. That said, I do think limiting the options to the two in the datasheet make a bit more sense. Either way it will allow a user to specify the address they need.

justacec commented 2 years ago

Ok, I am going to go ahead and close the PR in favor of the alternate approach. Thanks for taking the time to put the PR together.

justacec commented 2 years ago

Opps, I got this backwards (sigh). I will merge this one in vice the other approach.