ryansb / cfn-wrapper-python

Python decorator for making Lambda-backed CloudFormation resources
MIT License
71 stars 13 forks source link

Add Python3 support #5

Closed tmclaugh closed 7 years ago

ryansb commented 7 years ago

Hi, I'm looking into this, but as-is this PR breaks all the tests (oh no!) since they mock out the urlopen to intercept the HTTP requests. I'm looking at switching to vcrpy or similar instead of mocking, since that stubs in at a lower level meaning we can leave those conditionals.

The other alternatives are:

I'm working on the first one (use vcrpy) but first I'll add in #2 to make multi-env tests easier.

ryansb commented 7 years ago

Merged as https://github.com/ryansb/cfn-wrapper-python/commit/0a581aab84b34ce3e3398667782ef9c8433f2670 along with test changes.