search

ryansb / ofCourse

Python courseware leveraging Flask and OpenShift
Apache License 2.0
12 stars 14 forks source link

Yaml tests #28

Closed liam-middlebrook closed 9 years ago

liam-middlebrook commented 9 years ago

This should fix #1 and #16

\ Please Note: You'll need to edit the auto-generated tox.ini to point to this version of ofCourse and not my branch hosted here on GitHub. I've left it for now so you can confirm that this works. **

ryansb commented 9 years ago

I don't like this solution to getting travis for content repos. You don't need a setup.py and tox.ini to run the tests, it's doable with just a travis.yml and adding an ofcourse validate (or similar) subcommand and seems like a much better approach. I'd rather keep non-actual-content files to a minimum in content repositories.

Also, this will probably interfere with the way that openshift deployment works.

liam-middlebrook commented 9 years ago

Sounds good! I'll move that into ofcourse validate

liam-middlebrook commented 9 years ago

Okay this should be all good to go now. Once you merge this I think it would be a good time to cut a release. Once you do that we should be able to have the generated TravisCI tests work for any ofcourse instances.

ryansb commented 9 years ago

You know you can run those locally with tox -epep8 right? ;)

liam-middlebrook commented 9 years ago

I realized that as soon as I saw the build start. :+1:

ryansb commented 9 years ago

Awesome, thanks!