search

ryansb / ofCourse

Python courseware leveraging Flask and OpenShift
Apache License 2.0
12 stars 14 forks source link

Material design update #34

Closed mellolikejello closed 9 years ago

mellolikejello commented 9 years ago

Is this the best way to get a code review in? Let me know if there is a better way

ryansb commented 9 years ago

Do you have a migration plan for existing sites?

mellolikejello commented 9 years ago

Not yet, I can work on that next

ryansb commented 9 years ago

Yeah, what I'm most worried about is that existing sites may have some modified templates and end up with a weird mix of themes.

ryansb commented 9 years ago

Discussed with @decause, we'll just do a non-destructive sync of the templates to the existing sites. I'll add an ofcourse command to handle it.

Once the sync is done, the profs can use git add -p and accept only the changes they like.

ryansb commented 9 years ago

@mellolikejello This is great, I just whipped up the sync command and did a (test) migration of the HFOSS site. You can pull down the latest develop to try it yourself. :)

ryansb commented 9 years ago

Oh, I forgot to ask: is there an easy way for you to detect CSS and such that isn't being used anymore?

mellolikejello commented 9 years ago

awesome!

mellolikejello commented 9 years ago

I found a firefox plugin to find unused CSS https://addons.mozilla.org/en-us/firefox/addon/dust-me-selectors/ . There were a few others, but I wasn't sure how they'd work with ofcourse.

mellolikejello commented 9 years ago

There were just a few unused selectors in site.css. I can remove them