search

ryansheehan / terraria

Dockerfile for terraria
MIT License
291 stars 104 forks source link

Vanilla 1.4.4.9 release built from the wrong commit #149

Closed Danrs4114 closed 1 year ago

Danrs4114 commented 1 year ago

Hi

The Vanilla 1.4.4.9 release on GitHub and Docker Hub unfortunately seems to have been built from the wrong commit (Terraria Mobile). It should probably have been based on this pull request. 🙂

ryansheehan commented 1 year ago

I messed up the release, deleted the current one and rebuilding it now

On Thu, Nov 17, 2022 at 1:59 PM Danrs4114 @.***> wrote:

Hi

The Vanilla 1.4.4.9 release on GitHub https://github.com/ryansheehan/terraria/releases/tag/vanilla-1.4.4.9 and Docker Hub unfortunately seems to have been built from the wrong commit https://github.com/ryansheehan/terraria/commit/54a0f3bf8e19eeb2664e2a4e5cc86c91df87d880 (Terraria Mobile). It should probably have been based on this pull request https://github.com/ryansheehan/terraria/pull/148. 🙂

— Reply to this email directly, view it on GitHub https://github.com/ryansheehan/terraria/issues/149, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB46ER5SZST4TXMCWU6FG3TWI2FCXANCNFSM6AAAAAASDX7SUE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Danrs4114 commented 1 year ago

Perfect. Thank you. Kudos to you for the quick response, and in general for being quick to merge pull requests and build new releases 😀