Fixed attributes that were number only.

ryansolid / babel-plugin-jsx-dom-expressions

A JSX to DOM plugin that wraps expressions for fine grained change detection

MIT License

60 stars 10 forks source link

Fixed attributes that were number only. #21

Closed rbiggs closed 5 years ago

rbiggs commented 5 years ago

In HTML 3 you could have an attribute with a value of number:

However, since HTML 4 all attributes are required to be quoted. That means all HTML attribute values are string by default. There were quite a few attributes in here that were just numbers. The colspan and rowspan ones just bit me when I was building a table. So I've gone through and converted them all to union types of number | string like most of them already are.

ryansolid commented 5 years ago

Thanks for the PR