search

ryansolid / babel-plugin-jsx-dom-expressions

A JSX to DOM plugin that wraps expressions for fine grained change detection
MIT License
60 stars 10 forks source link

[Types] Missing class property in HTMLAttributes definition #34

Closed amoutonbrady closed 4 years ago

amoutonbrady commented 4 years ago

Hey there, first and foremost thanks for making that library (and the ecosystem around it, especially Solid). Working with it for a small internal project has been delightful.

I use VSCode as my main code editor and being based on TS, it automatically lint JS files, which is quite useful because you then have access to all the autosuggestions, etc.

In the latest release you improved a lot on the typing for the custom control flow elements. I was having quite some errors there. They are now gone! Thank you.

There's just a last little thing that's been bothering me. As the title say, in the types there are no definition for the class attribute on HTMLAttributes. I was wondering if it would be possible to add it or if that was intentional?

Here's the part where I think it should be next to className.

Anyway, keep rocking!

ryansolid commented 4 years ago

Thanks for pointing this out. for was missing too. Fixed in v0.15.1.