ryansolid / dom-expressions

A Fine-Grained Runtime for Performant DOM Rendering
MIT License
885 stars 127 forks source link

sometimes elements are missing from output DOM #132

Closed trusktr closed 2 years ago

trusktr commented 2 years ago

Turns out #131 was two issues in one, so I renamed that one, and made a new one for the second issue.

Sometimes the template doesn't output DOM (missing elements). In the next example, the root element is ignored completely, doesn't get output to the DOM:

https://playground.solidjs.com/?hash=589409240&version=1.3.16

A recent update to playground within the past two days broke its ability to import code (https://github.com/solidjs/solid-playground/issues/108), and this example currently shows Failed to fetch dynamically imported module: data:text/javascript;.... in the console, so it currently can not show the problem.

Here's the corrected playground with with imports fixed, but it no longer reproduces the issue:

https://playground.solidjs.com/?hash=-948883626&version=1.3.16

It was my mistake, I didn't see an import error in the old UI console, so I assumed it worked, but the new UI console properly shows the import error.