Remove `@babel/plugin-syntax-jsx`

ryansolid / dom-expressions

A Fine-Grained Runtime for Performant DOM Rendering

MIT License

865 stars 124 forks source link

Closed lxsmnsyc closed 2 years ago

lxsmnsyc commented 2 years ago

@babel/plugin-syntax-jsx has a weird semver for babel as peerDependency: @babel/core@^7.0.0-0. It will always complain regardless of the babel version.
@babel/plugin-syntax-jsx is basically optional, 'jsx' is already built into the core and can be accessed through parserOptions, which is what @babel/plugin-syntax-jsx is doing internally.

lxsmnsyc commented 2 years ago

I guess I'll just close this. I checked the semver and the range is fine, but not with pnpm.

ryansolid commented 2 years ago

Are you saying this isn't worth doing?

lxsmnsyc commented 2 years ago

@ryansolid I'm just thinking "maybe". TBF the plugin itself is bloatware