Treat `attribute={true}` like `attribute=""`

ryansolid / dom-expressions

A Fine-Grained Runtime for Performant DOM Rendering

MIT License

885 stars 127 forks source link

Treat `attribute={true}` like `attribute=""` #141

Closed edemaine closed 2 years ago

edemaine commented 2 years ago

Fixes https://github.com/solidjs/solid/issues/1101 by making <div foo={true}> (and <Div foo={true}> behave like <div foo> and <div foo=""> i.e. HTML Boolean attributes.

It would be good to add tests for this... but I could use help as I haven't touched the tests before.

ryansolid commented 2 years ago

Thanks for the PR. Not going this direction though from the conclusion of the discussion. The decision was to keep the current behavior and update SSR to reflect it.